Skip to content

Remove dead Helm Repository's IsInsecure method#7776

Merged
twz123 merged 1 commit into
k0sproject:mainfrom
twz123:remove-isinsecure
Jun 19, 2026
Merged

Remove dead Helm Repository's IsInsecure method#7776
twz123 merged 1 commit into
k0sproject:mainfrom
twz123:remove-isinsecure

Conversation

@twz123

@twz123 twz123 commented Jun 10, 2026

Copy link
Copy Markdown
Member

Description

In #7083, the evaluation of the insecure field was moved from the API's struct to a struct owned by the extensions controller. This left the IsInsecure method without any callers. Remove it.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

In 5774b2e, the evaluation of the insecure field was moved from the
API's struct to a struct owned by the extensions controller. This left
the IsInsecure method without any callers. Remove it.

See: 5774b2e ("Add secret-based repository auth for Charts")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 marked this pull request as ready for review June 11, 2026 08:14
@twz123 twz123 requested review from a team as code owners June 11, 2026 08:14
@twz123 twz123 requested review from jnummelin and kke June 11, 2026 08:14
@twz123 twz123 enabled auto-merge June 11, 2026 08:56
@twz123 twz123 disabled auto-merge June 19, 2026 10:33
@twz123 twz123 merged commit 2f230ac into k0sproject:main Jun 19, 2026
314 of 318 checks passed
@twz123 twz123 deleted the remove-isinsecure branch June 19, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants