Skip to content

fix: change priorityclass default for nllb pod #7787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twz123 merged 5 commits into from
Jun 19, 2026
+26 −0
Merged

fix: change priorityclass default for nllb pod #7787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c28ff7
fix: change priorityclass default
cmwylie19 Jun 11, 2026
7763ba1
chore: system-node-critical priority value
cmwylie19 Jun 14, 2026
30966f3
chore: fix test
cmwylie19 Jun 17, 2026
edd0566
chore: bump timeout
cmwylie19 Jun 18, 2026
c809852
chore: revert timeout
cmwylie19 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/component/worker/nllb/envoy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,19 @@ func makePodManifest(params *envoyParams, podParams *envoyPodParams) corev1.Pod
},
Spec: corev1.PodSpec{
HostNetwork: true,
// The Envoy Pod is the worker's load-balanced path to the control
// plane, so it must outlive ordinary workloads during graceful node
// shutdown and be protected from node-pressure eviction.
//
// PriorityClassName satisfies the kube-apiserver Priority admission
// controller, which validates the mirror Pod the kubelet registers
// for this static Pod. The numeric Priority is also set so the local
// kubelet (which does not resolve PriorityClassName for static Pods)
// uses it for shutdown/eviction ordering. The two must agree:
// admission computes the integer from the class name and rejects the
// mirror Pod if an explicit, mismatched Priority is provided.
PriorityClassName: "system-node-critical",
Priority: ptr.To(int32(2000001000)),
SecurityContext: &corev1.PodSecurityContext{
RunAsNonRoot: ptr.To(true),
},
Expand Down
13 changes: 13 additions & 0 deletions pkg/component/worker/nllb/traefik.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,19 @@ func makeTraefikPodManifest(podParams *traefikPodParams, installConfig *traefikI
},
Spec: corev1.PodSpec{
HostNetwork: true,
// The Traefik Pod is the worker's load-balanced path to the control
// plane, so it must outlive ordinary workloads during graceful node
// shutdown and be protected from node-pressure eviction.
//
// PriorityClassName satisfies the kube-apiserver Priority admission
// controller, which validates the mirror Pod the kubelet registers
// for this static Pod. The numeric Priority is also set so the local
// kubelet (which does not resolve PriorityClassName for static Pods)
// uses it for shutdown/eviction ordering. The two must agree:
// admission computes the integer from the class name and rejects the
// mirror Pod if an explicit, mismatched Priority is provided.
PriorityClassName: "system-node-critical",
Priority: ptr.To(int32(2000001000)),
SecurityContext: &corev1.PodSecurityContext{
RunAsNonRoot: ptr.To(true),
// https://kubernetes.io/docs/tasks/configure-pod-container/create-hostprocess-pod/
Expand Down
Loading