Renew etcd certificates generated by custom etcd CA#7796
Conversation
623cb17 to
6b781e4
Compare
k0s renews certs issued by a custom cluster CA, and it should do the same for certs issued by a custom etcd CA. Fixes k0sproject#7795 Signed-off-by: Dmitrii Shishliannikov <dshishliannikov@mirantis.com>
6b781e4 to
ceae598
Compare
|
@twz123 thanks for replaying the tests for me. I looked into the logs from the failed runs and discovered an actual issue with my change. It turned out there are 2 independent cert managers; etcd has its own, and the order of operation is as follows:
The failure is on step 1 where we expect etcd CA to be created, but it's only created on step 3, so step 1 fails with I made a change so that I log a warning instead of failing when etcd CA isn't present - https://github.com/k0sproject/k0s/pull/7796/changes#diff-a79868c58696b375941a0e5a2b1787adab963bde4947a06d3f2402e131ba3c3bR226-R232 It should work now. |
|
it seems to me the test failures are unrelated to my change. Some happened even before the test started: |
Description
k0s renews certs issued by a custom cluster CA,
and it should do the same for certs issued by
a custom etcd CA.
Fixes #7795
Type of change
How Has This Been Tested?
Checklist