Up n Down#210
Conversation
📁 Previous CI results (run #20799774671)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2025-12-21 19:00:37 UTC. |
|
ALE Similarity: 2.5 / 4
Implementation Quality: 4 / 4 The code is fully JAX-native, with no Python loops used in the core logic and all state updates expressed through pure functions. The overall structure is clear and well modularized, and the code is thoroughly commented, making peer review and further development straightforward. The game loads instantly and runs smoothly, with no noticeable performance issues. Additionally, the current implementation is sufficiently modular and flexible to support gameplay modifications. Overall, this is already a solid and well-structured reimplementation of the original UpNDown. While some gameplay details differ a little bit from the original, the core systems are there and behave accordingly. Thanks to the clean, modular, and JAX-compatible design, the implementation is well suited for further balancing and extension. |
|
Hi, this is the review of the team working on Darkchambers: ALE-Similarity: 3 / 4Overall already great. Here are some points we noticed: Gameplay & Mechanics
Code Quality: 3.5 / 4What’s good
Where you could optimize
Performance: 4 / 4
|
📁 Previous CI results (run #21547230802)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-01-07 23:30:55 UTC. |
📁 Previous CI results (run #22721145414)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: freeway ❌ |
Planed Mods:Simple mods:
Difficult Mods:
If there is a problem with some of the planed mods please let us know @PaulSeitz |
📁 Previous CI results (run #22763292280)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: upndown ❌ |
📁 Previous CI results (run #22763789740)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: upndown ❌ |
📁 Previous CI results (run #23384723074)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: upndown ❌ |
📁 Previous CI results (run #23385404396)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: tennis ✅frostbite ✅asteroids ❌ |
📁 Previous CI results (run #23387019406)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: asteroids ❌upndown ❌ |
📁 Previous CI results (run #23387247904)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: asteroids ❌upndown ❌ |
fc84b29 to
68443a2
Compare
📁 Previous CI results (run #23387375382)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: upndown ❌ |
📁 Previous CI results (run #23410964625)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: upndown ❌ |
📁 Previous CI results (run #23465833201)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-22 19:51:55 UTC. |
📁 Previous CI results (run #23687725803)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-24 00:00:29 UTC. |
Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-28 15:09:54 UTC. |
python scripts/play.py -g UpNDown
Known Bugs: