Final Submission: Tutankham#222
Open
JTense wants to merge 148 commits into
Open
Conversation
Added a test section to the README.
(update_score does not work yet and will not be executed in the step() function
# Conflicts: # src/jaxatari/games/jax_tutankham.py
creature step and spawn_step are now separate functions (spawner_Step not in jax yet)
…_and_renderer # Conflicts: # src/jaxatari/games/jax_tutankham.py
📁 Previous CI results (run #20430118276)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ❌The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: tutankham ❌This log was automatically created at 2025-12-22 10:49:56 UTC. |
📁 Previous CI results (run #23058397069)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: tutankham ❌This log was automatically created at 2025-12-22 11:10:02 UTC. |
|
Hi, following is the review by the team that is working on Battlezone: As written in the fork comment by the authors many Features are currently only implemented in "normal" python / not jax compatible. I will only review the jax compatible code (we understood that as the point of the review) ALE-similarity: implementation quality: |
|
Hi, this is the review of the team working on Darkchambers: ALE-Similarity: 1.5 / 4The current implementation differs significantly from the ALE version and does not yet reproduce the core gameplay challenge:
Overall, gameplay currently only resembles ALE at a very basic movement level. Code Quality: 2 / 4 (JAX-Native)Things that could be improved
Performance: 3 / 4
|
Collaborator
|
Hey there. So I see that the reviews were mostly more on the negative side because the JAX version of your project is still just the bare backbone of the game (and I understood that you first implemented most of the game logic in pure python, right?). That totally okay, we ourselves said that this is fine to do. The downside for you of course now is that you did not really get "real" feedback on what you were working on. My proposal would be to "integrate" the feedback (where possible) and keep porting your work to JAX, make the tests pass, etc. Keep up the good work! |
📁 Previous CI results (run #23508329204)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ❌Some framework tests failed. Please check the details below: tutankham ❌ |
📁 Previous CI results (run #23555565967)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-24 19:37:09 UTC. |
📁 Previous CI results (run #23614002605)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-25 17:54:34 UTC. |
📁 Previous CI results (run #23617808992)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-26 19:39:40 UTC. |
📁 Previous CI results (run #23618195028)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-26 21:10:20 UTC. |
📁 Previous CI results (run #23631273380)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: tutankham ❌ |
… and tutankham_mod_plugins Compability for Whip and Mimic Mod Add mimic and whip observation and hook Add new playermovement logic Resolve laser flash count before adding level Observation space cleanup
📁 Previous CI results (run #23631581127)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ❌Some framework tests failed. Please check the details below: tutankham ❌This log was automatically created at 2026-03-27 04:40:22 UTC. |
📁 Previous CI results (run #23631605794)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ❌The PR changes files that should not be changed:
Please ensure that only allowed files are modified. Any changes in the Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-27 04:54:13 UTC. |
📁 Previous CI results (run #23684773063)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-27 04:55:08 UTC. |
📁 Previous CI results (run #23687431524)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-28 12:10:49 UTC. |
📁 Previous CI results (run #23758752784)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-28 14:47:26 UTC. |
Added level parameter to collision
📁 Previous CI results (run #23760333695)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-30 17:47:11 UTC. |
📁 Previous CI results (run #23764108257)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-30 18:23:46 UTC. |
📁 Previous CI results (run #23768118195)Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-30 19:51:29 UTC. |
Test ReportThis comment was generated automatically by a GitHub Action. It summarizes the test results for this pull request. The GitHub Action run can be found here: Base Branch ✅The PR's base branch is Changed Files ✅There are no forbidden file changes. Nice 👍 Framework Tests ✅All framework tests passed. Good work! 🎉 This log was automatically created at 2026-03-30 21:24:55 UTC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a not fully implemented Version of Tutankham.
What functions are currently working:
What functions are currently existing but not in JAX:
What functions are currently missing: