Conversation
Ship ten frozen slideshow-farm lessons under budgetr.dev/learn with shared brass accent type, Guides nav links, and the Mac/SQLite closer pointing at /overview. Co-authored-by: Kevin George <kGeee@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kGeee
changed the title
Title-case guide hooks, gold lead + short teach paragraphs, card index with sample-data footer CTA, and frozen Mac/SQLite closer to /overview. Co-authored-by: Kevin George <kGeee@users.noreply.github.com>
kGeee
left a comment
kGeee
left a comment
There was a problem hiding this comment.
Verdict: COMMENT (hold — do not ship) — head 7e955dd
CI green (web). Still a draft. Title and agent-log are explicit: hold the 10-hook slideshow /learn — Kowalski/Marketing Chief locked /learn as a knowledge path with new curriculum incoming. Not an approve. Do not merge.
Code vs PR brief (for when the hold lifts)
| Item | Status |
|---|---|
10 guides in web/lib/learn.ts with long slugs |
Pass |
Index H1 / sub / cards + /learn/[slug] + generateStaticParams |
Pass |
Shared closer → /overview (not DMG) |
Pass |
| Guides in header + footer; Download untouched | Pass |
| No Plaid, screenshots, demo $, Copilot pricing, $29 | Pass |
Under (marketing) |
Pass |
| No secrets | Pass |
Soft (non-blocking)
LearnCloserrenders two links to the samehref(Try the live demo/budgetr.dev/overview) — fine, slightly redundant.- Teach copy is very short (slideshow-farm); fine for this PR, expect rewrite under the knowledge-path lock.
@pr Merger stay off until undraft and the HOLD title/lock is cleared. I will not merge.
Screenshots (current state)One still of
(URL will resolve after screenshot commit lands — follow-up comment with final SHA.) |
Attach one current-state still of the HOLD education-farm /learn index. Co-authored-by: Kevin George <kGeee@users.noreply.github.com>
|
Screenshot SHA:
Note: Vercel preview |
Replace the still with one rendered from the protected preview HTML fetched via the provided _vercel_share link. Co-authored-by: Kevin George <kGeee@users.noreply.github.com>
Screenshot (from provided share URL)Fetched preview HTML via: One still of SHA:
|
kGeee
left a comment
kGeee
left a comment
There was a problem hiding this comment.
Verdict: COMMENT (hold — do not ship) — head 5aed861
Screenshot gate: PASS — current-state /learn still attached for this tip (comment; .pr-screenshots/learn-index.png on 5aed861). CI green (web + Vercel preview). Still a draft. Title remains HOLD and the knowledge-path rewrite lives on #41 — even with screenshot PASS this is not shippable. Not an approve. Do not merge.
Re-check vs prior review (7e955dd)
| Item | Status |
|---|---|
10 guides in web/lib/learn.ts with long slugs |
Pass |
Index H1 / sub / cards + /learn/[slug] + generateStaticParams |
Pass |
Shared closer → /overview (not DMG) |
Pass |
| Guides in header + footer; Download untouched | Pass |
| No Plaid, demo $, Copilot pricing, $29 | Pass |
Under (marketing) |
Pass |
| Screenshot on this tip SHA | Pass |
| No secrets in text diffs | Pass |
Soft (non-blocking)
LearnCloserstill dual-links the samehref(Try the live demo/budgetr.dev/overview) — fine, slightly redundant.- Slideshow-farm copy remains intentional for this branch; expect rewrite under the #41 knowledge-path lock.
@pr Merger stay off until undraft and the HOLD title/lock is cleared (knowledge path is #41). I will not merge.
kGeee
left a comment
kGeee
left a comment
There was a problem hiding this comment.
Verdict: COMMENT (hold — do not ship) — head 5aed861
CI green (web + Vercel Preview Comments). Still a draft. Title + agent-log still lock this: Kowalski/Marketing Chief hold the 10-hook slideshow /learn — knowledge path / new curriculum incoming. Not an approve. Do not merge.
Screenshot gate
Cleared for this head. Current-state still of /learn farm index is on the branch (.pr-screenshots/learn-index.png, refreshed from the share URL at 5aed861). Preview remained SSO-blocked for unauthenticated fetch; capture path is documented in the PR comments.
Code vs PR brief (unchanged since 7e955dd; still holds)
| Item | Status |
|---|---|
10 guides in web/lib/learn.ts with long slugs |
Pass |
Index H1 / sub / cards + /learn/[slug] + generateStaticParams |
Pass |
Shared closer → /overview (not DMG) |
Pass |
| Guides in header + footer; Download untouched | Pass |
| No Plaid, screenshots-in-product, demo $, Copilot pricing, $29 | Pass |
Under (marketing) |
Pass |
| No secrets | Pass |
Soft (non-blocking)
LearnCloserstill double-links the samehref(Try the live demo/budgetr.dev/overview) — fine, slightly redundant.- Teach copy stays slideshow-short; expect rewrite under the knowledge-path lock.
@pr Merger stay off until undraft and the HOLD title/lock is cleared. I will not merge.
2 participants
Ship
budgetr.dev/learnas ten short education pages (slideshow-farm copy), linked from marketing header/footer as Guides.What
web/lib/learn.tswith the 10 frozen guides (locked long slugs)/learn: H1 “Personal finance, one number at a time.”, sub “Short guides. The Mac app is optional.”, cards for the 10 hooks, footer CTA to/overviewsample demo/learn/[slug]viagenerateStaticParams— title-case H1, gold lead, short teach paragraphs/overview(not a DMG)Constraints honored
/privacyor/terms(marketing)/MARKETING_ONLYmain; does not touch Windows NSIS installer + first-run privacy gate #35 / marketing: homepage hero slogan + two first-class CTAs #36 / apple: fix Budgets spend resolution and first-run import wiring #37Screenshots
Source: Vercel share URL for this branch’s
/learnpreview.Test plan
MARKETING_ONLY=1preview:/learn+ all 10 slugs return 200/learn; Download CTA still present/overviewHead:
5aed8618ee5b29b10c3c7fe5fae3a1e1d3b825e8