Skip to content

fix: fix MPI race condition in permittivity file output #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yxpw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix MPI race condition in permittivity file output #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/functions/optics/permittivity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ void CalcOptPermit::at_k(FracCoord k_frac) {


void CalcOptPermit::save_data() {
// Only the root rank output data!
if (!UtilsMPI::i_am_root_rank()) return;
// Check and prepare
UtilsMisc::check_output_directory_is_ok();
std::ofstream outputFile(PERMITTIVITY_OUT);
// Check if the file open with no error
if (!outputFile) UtilsMPI::Abort() << "Fail to create the output file.";
// Only the root rank output data!
if (!UtilsMPI::i_am_root_rank()) return;
// Write the data to file
for (size_t i_w=0; i_w<omega_num; ++i_w) {
outputFile << omega_list[i_w] << " " << global_optics_values[i_w].real() << " " << global_optics_values[i_w].imag() << std::endl;
Expand Down