test(e2e): stop flaky Firefox NS_BINDING_ABORTED noise from blocking deploys#34
Merged
Conversation
Rapidly navigating analysis routes aborts in-flight resource/worker loads; Firefox surfaces the abort via Playwright's juggler harness as a console error (NS_BINDING_ABORTED), which flakily failed the no-console-errors assertion and blocked the Build/Deploy pipeline. It is not an application fault — add it to the existing benign-noise filter (alongside React Router and DevTools).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The post-#33
mainCI run failed, which blocked the Build → Deploy to GitHub Pages chain (Deploy depends on all E2E passing). The failing job was E2E Tests (Firefox) —tests/e2e/analysis.spec.ts:618, which asserts no console errors after navigating the analysis routes:This is benign, flaky Firefox noise, not an app fault: the test loops
page.gotoacross four routes in quick succession, which aborts in-flight resource/worker loads; Firefox surfaces the abort through Playwright's juggler harness asNS_BINDING_ABORTED. The same test passed on the #33 PR run — it's a flake, and it's unrelated to the Signal Viewer changes.Fix
The assertion already filters benign console noise (React Router, DevTools). Add
NS_BINDING_ABORTEDto that allow-list so this spurious Firefox abort can't flakily block deploys. One-line change in the test; no production code touched.Merging this re-runs
mainCI and (when green) deploys #33's changes that the flake held back.🤖 Generated with Claude Code
https://claude.ai/code/session_012CzEJ1kUhwobqVTnVusLcb
Generated by Claude Code