Repository navigation
feat: add review controls, agent usage, security digest - #8
Merged
Merged
Conversation
- Retry failed or cancelled reviews and cancel queued or running ones from the dashboard. Admin only. A per-PR lock and the worker lease keep retries from racing pushes or overlapping a stopping run. - Explain failed and cancelled reviews in plain words. Keep the raw error under Error details. - Record agent time and the token usage that each CLI reports. Codex runs with --json. Show harness availability from the model list check. - Add an opt-in weekly security digest. It posts new, fixed, and overdue Dependabot alerts to an HTTPS chat webhook. Delivery connects only to public addresses and never exposes the URL. - Store findings before posting and mark them published with the GitHub review ID in one transaction.
Seal the URL with AES-256-GCM under an HKDF key derived from the GitHub App private key. Bind the installation ID as associated data. Keep only the host in plain text for display. A database dump alone no longer reveals the URL. After an App key rotation the digest reports an error and the admin enters the URL again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds three of the four requested features. The fix priority queue (feature 1) shipped in #7 and is part of v0.5.0. It already sorts by severity, EPSS exploit probability, and patch availability from the Dependabot API.
Review controls
POST /api/v1/reviews/{id}/retryandPOST /api/v1/reviews/{id}/cancel. Both requirecan_admin.409.superseded.Agent health and usage
modelUsageturn.completed. Codex now runs with--json.step_finishGET /agentsreturnshealth, the result of the latest model list run in the sandbox. This check does not test credentials.GET /statsreturns per-agent reviews, median agent time, tokens, and models.Weekly security digest
/slack.tokio-rustlsandwebpki-roots. Both were already inCargo.lock. OSV reports no advisories for them.Publication record
Migration
0004_usage_health_digest.sqladds nullable columns toreviews,agent_models, andinstallations. Runcrocode migratebefore starting the new API and worker.Validation
cargo fmt --all --check,cargo clippy --all-targets -- -D warningscargo test --all -- --include-ignoredon Postgres 17: 62 passed, including new tests for the retry and cancel rules, usage stats, digest claims, URL sealing, and URL privacy.node --test crates/server/src/osv.test.mjs: 6 passed.web/:bun run lint,bun run typecheck,bun test(49 passed),bun run build,bun run build:docs,scripts/check-docs-export.ts, andscripts/smoke.ts. The smoke test covers agent health, the retry action, and digest settings.404.Known limits
step_finishtoken shape live, because the free tier hit its limit. The parser follows the documented event fields.