chore: missing 0.4.9 changelog, de-flake timing tests, small cleanups - #357
Merged
Conversation
…at cleanup - CHANGELOG: add the missing 0.4.9 entry (v0.4.8..v0.4.9 spanned 58 commits including bitmap commands, LMPOP/ZMPOP, keyspace notifications, the ts client, and 39 new grpc rpcs but was never recorded); correct the 0.4.8 claim that concurrent mode was removed — the mode still exists behind --concurrent - blocking tests: replace sleep-then-try_recv with recv under a generous timeout so a starved runner can't flake blpop/brpop tests - persistence test: widen the post-shutdown flush wait (the final AOF sync runs asynchronously in the shard task after the handle drops) - MSETNX defensive arity error now matches the parser's canonical WrongArity format - sorted set: debug_assert that the score map and sorted vec stay in lockstep at mutation entry points
kacy
added a commit
that referenced
this pull request
Jul 3, 2026
…at cleanup (#357) - CHANGELOG: add the missing 0.4.9 entry (v0.4.8..v0.4.9 spanned 58 commits including bitmap commands, LMPOP/ZMPOP, keyspace notifications, the ts client, and 39 new grpc rpcs but was never recorded); correct the 0.4.8 claim that concurrent mode was removed — the mode still exists behind --concurrent - blocking tests: replace sleep-then-try_recv with recv under a generous timeout so a starved runner can't flake blpop/brpop tests - persistence test: widen the post-shutdown flush wait (the final AOF sync runs asynchronously in the shard task after the handle drops) - MSETNX defensive arity error now matches the parser's canonical WrongArity format - sorted set: debug_assert that the score map and sorted vec stay in lockstep at mutation entry points
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of a 5-PR cleanup series from a full-codebase audit.
What
--concurrent(a follow-up PR deprecates it explicitly).shard/blocking.rs): two tests slept 50ms then assertedtry_recv()succeeded — a starved CI runner fails that. They nowrecv()under a 5s timeout: event-driven, faster in the common case, and only fails on a genuine hang. The other timing tests in core were audited and left alone deliberately — they assert in the flake-safe direction (extra delay only makes an expired key more expired).debug_assertthe score-map/sorted-vec invariant that its internalunwrap()s rely on.Verification
cargo test -p emberkv-core(597) and-p ember-server --features protobuf,grpc(143) pass;clippy -D warningsclean;cargo fmtapplied.