fix(sync): point stale toku sync init guidance at signup/login/enroll - #231
Merged
Conversation
kafkade
enabled auto-merge (squash)
July 28, 2026 00:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three small follow-ups from epic #207: the CLI still told users to run the deprecated
toku sync init, and two docs files described a reality the tree has moved past.What's included
Stale sync guidance (CLI: stale error strings point users at deprecated
toku sync init#221) — every error/hint that pointed at the deprecatedtoku sync initnow names the command that actually fits its situation:toku sync signup(new account) /toku sync enroll(existing account)toku sync logintoku sync disable→toku sync enrollto re-enable. (Checked the code rather than guessing:orchestrator::login()only mints a device session whenconfig.syncstill carries adevice_id, anddisableclears it — sologinalone cannot restore sync.)toku sync compactwith no device identity →signup/enrollloginto unlock with password + Secret Key, orenrollto enroll the deviceFixed in
crates/toku-cli/src/main.rsand incrates/toku-sync-client/src/orchestrator.rs. The latter is not named in the issue, but its errors are printed verbatim bytoku sync push/pull/bootstrap, so they are CLI error strings and fall under the same acceptance criterion.The deprecated
toku sync initcommand, its[Deprecated]help text, and its runtime deprecation notice are unchanged — only guidance text moved. No behavior change, and no test asserted on any of these strings.ROADMAP §7.5 (Docs: ROADMAP §7.5 still marks self-hosted sync server 🔴 "Deferred" though it shipped #224) — "Self-Hosted Sync Server" was 🔴 "Deferred to Phase 7" while the server has actually shipped. Now 🟡 with a shipped/remaining split matching the existing Phase 7 style: shipped = the Axum
toku-syncserver (ADR-008 wire protocol), mandatory zero-knowledge E2E, two-secret SRP (ADR-010), the self-hostable Docker image with first-run admin onboarding, op-log emission (Sync: generate ops for every frontend mutation (CLI/FFI/web/import) #194) and new-device bootstrap (Sync: upload existing state on first opt-in + wire/expose new-device bootstrap #199); remaining = genuine multi-device client integration across iOS/macOS/web/Windows. A short bullet notes the managed-tier controls from Managed-tier server hardening: per-user quotas, rate limiting, server backup, signup #206 (per-user quotas, per-user rate limiting, admin-scoped encrypted backup, signup email verification), which are off by default and preserve the zero-knowledge guarantee. Each claim was verified against the tree, not copied from the issue text. The export table's backup row was also aligned toPhase 2 ✅ (#200)so it keeps planned-phase info like its neighbors.Agent instructions (Docs: copilot-instructions references non-existent
.github/workflows/ci.yml(actual file isvalidate.yml) #228) — the CI/infrastructure note pointed at.github/workflows/ci.yml, which does not exist. Corrected to.github/workflows/validate.yml(workflowname: CI, gating jobValidate). No stale reference remains repo-wide.Note on scope
One hunk is a deliberate extra, outside the issue's stated scope:
crates/toku-web/src/views.rs:62, the read-only sync page copy, which had the same staletoku sync initinstruction. #221 is scoped to CLI messages, so this is a different surface (web copy). It's one line and leaving it wrong seemed worse than fixing it — but it is cleanly separable and can be dropped without affecting anything else in this PR.No CI job was renamed, added, or removed, so no
kafkade/github-infraTerraform change is needed.Related Issues
Closes #221
Closes #224
Closes #228
Type of Change
Crate
toku-core— Domain models, traits, state machinetoku-db— SQLite persistence, migrations, FTS5toku-import— Importers (Goodreads, Calibre, StoryGraph)toku-meta— Metadata fetching (Open Library, Google Books)toku-cli— CLI binarytoku-export— Exporters (CSV, JSON, Markdown, BibTeX)docs/— Documentation (ROADMAP.md,.github/copilot-instructions.md)Also touched:
toku-sync-client(CLI-visible sync errors) andtoku-web(sync page copy — the out-of-scope extra noted above).Data Integrity Checklist
Checklist
cargo fmt --checkpassescargo clippy --workspace -- -D warningspassescargo test --workspacepasses