Polish filter chips bar into a branded, theme-correct control - #42
Merged
Conversation
Give the active-filters bar a deliberate treatment matching the search-bar/game-card revamp, with no behavior changes: - Leading label becomes a small branded section marker (tag glyph + uppercase, letter-spaced text), echoing the sidebar section headers. - Filter chips use the shared close glyph (AppIcons.ACT_CLOSE) with a richer hover/pressed treatment driven entirely by design tokens. - "Clear all" becomes a subtle outlined accent pill with a leading close glyph instead of a bare text link, so the reset reads as a real control. All spacing/radius/color pulled from theme tokens. Full suite green (278 passed); no net-new ruff warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B8zTzGW6CyEgVDQ4UbdF5G
kaihuang1425
added a commit
that referenced
this pull request
Jun 30, 2026
…-4xx760 Polish filter chips bar into a branded, theme-correct control
kaihuang1425
added a commit
that referenced
this pull request
Jun 30, 2026
Bring the multi-select batch toolbar in line with the app's visual revamp (search bar #41, game card #40, filter chips #42). Presentation only — every signal, slot, and selection behavior is untouched. - Accent-emphasized selection count ("<n> games selected", number in the accent color) with correct singular/plural noun. - Action buttons (Set Status / Add Tag / Add to Collection) gain icons and a clean neutral-to-accent hover/pressed treatment; the Set Status dropdown hides the native menu indicator in favor of its own chevron glyph, and the status menu entries carry their semantic status icons. - Select All / Clear recede to shared ghost-button styling since they are selection plumbing, not primary actions. - "Done" becomes the primary filled-accent pill that closes batch mode. - Slim vertical dividers separate logical button groups, and the floating surface gains a subtle accent border so the bar reads as a distinct, temporary mode over the grid. - All spacing/radius/color come from existing theme tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the app's visual revamp by giving the active-filters bar (
widgets/filter_chips.py) a deliberate, theme-correct treatment, mirroring the branded look landed for the search bar (#41), game card (#40), and splash/empty states (#39). No behavior changes — filter parsing, add/remove, and clear-all logic are untouched; this is purely presentation.What changed (
widgets/filter_chips.py)Filters:becomes a small section marker (AppIcons.UI_TAGglyph + uppercase, letter-spacedFILTERS), echoing the sidebar section headers so the bar announces itself consistently.AppIcons.ACT_CLOSE) instead of a raw×, with a richer hover/pressed treatment (accent border lift + pressed darken) driven entirely by design tokens.radius_pill, accent-tinted hover/pressed), so the reset reads as a real control.spacing_xs/sm,radius_pill,accent,chip_border,text_muted).Process notes
Per the task, I first handled outstanding PRs. The only open/unmerged PR was #41 (search-bar polish) — it had no review or general comments to reply to, all 4 CI checks were green, and it was
mergeable_state: clean, so I merged it intomain(no conflicts) and rebuilt this branch on the updatedmain.Testing
PYTHONPATH=src pytest src/tests/→ 278 passed.py_compileclean;ruff check --select E,W,Fintroduces no net-new warnings (only a pre-existing E501 inbuild_filter_chipsremains).