Protect topic attribute actions from CSRF - #4
Merged
kaileymsnay merged 1 commit intoAug 29, 2026
Merged
Conversation
StudioMaX
force-pushed
the
fix/csrf-attribute-actions
branch
from
August 29, 2026 08:06
497a0ea to
1890ca6
Compare
StudioMaX
marked this pull request as ready for review
August 29, 2026 08:09
Owner
|
Thank you for the contribution. A note on tests - this extension doesn't fully implement functional tests, so the one included in you pull request would never run (see https://github.com/kaileymsnay/qte/blob/master/.github/workflows/tests.yml#L53-L66). This is something I never utilized, but looking to at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
An authorised topic author could change an attribute by visiting viewtopic.php?t=62&attr_id=1; no form key, link hash, or confirmation was required. A page on another origin successfully top-level-navigated an authenticated browser to that URL and changed the topic attribute.
Verification