Skip to content

branch to merge all card branches into - #1

Open
kainacrow wants to merge 21 commits into
masterfrom
integration-branch-cards
Open

kainacrow wants to merge 21 commits into
masterfrom
integration-branch-cards

Conversation

@kainacrow

@kainacrow kainacrow commented Jul 23, 2023

Copy link
Copy Markdown
Owner

This PR handles various additions:

  1. A supplier is always required for a contract.

  2. Creating a contract via a CSV import. If a supplier is not present, then a contract will not be created when importing via a CSV. If a contract already exists it won't be created again. If a supplier already exists it won't be created again. This pops up via a modal - but the page does require a refresh to be loaded. I'm also not sure why the content missing part shows up but I looked over a tutorial for building modals using turbo as I was unfamiliar and that's as far as I was able to get.

  3. The ability to click on a supplier name on the contracts table and be taken to a dashboard where it will show all the contracts associated with that specific supplier.

  4. On the supplier view, an average contract value will be displayed in the right corner.

  5. I added functionality for suppliers to not be created if one already exists. I did this by scrubbing the empty space before/after the string then removing blank spaces within, then removing "LLC" as that is how some duplicates were showing up

  6. I removed N+1 queries by using eager loading to fetch the associated contract_owner and supplier for contracts and loading contracts and their contract_owners for the supplier

  7. I also added specs for the controllers and specs for the new model and factories as well.

@kainacrow
kainacrow force-pushed the integration-branch-cards branch from 4c68e9d to b7975a1 Compare July 23, 2023 18:22
@kainacrow
kainacrow force-pushed the integration-branch-cards branch from b7975a1 to 48997ab Compare July 23, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant