Removed environment variables and added docker secrets for more security#20
Open
MauritzFunke wants to merge 1 commit intokaitallaoua:masterfrom
Open
Removed environment variables and added docker secrets for more security#20MauritzFunke wants to merge 1 commit intokaitallaoua:masterfrom
MauritzFunke wants to merge 1 commit intokaitallaoua:masterfrom
Conversation
kaitallaoua
reviewed
Mar 29, 2024
| _PASSWORD = os.environ.get("PASSWORD", None) | ||
| _USERNAME = None | ||
| _PASSWORD = None | ||
| with open("/run/secrets/spotify_login") as login: |
Owner
There was a problem hiding this comment.
Nitpick but can you use pathlib for this purpose. something like json.loads(Path('path/filename').read_text()
kaitallaoua
requested changes
Mar 29, 2024
Owner
kaitallaoua
left a comment
kaitallaoua
left a comment
There was a problem hiding this comment.
Cool. I still have to test but I like the idea. Only other nitpick is can the json file be called login.json. Its not really a configuration file at present.
Owner
|
Also this currently breaks running the program without docker, as it always tries to load the login file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.