Skip to content

Fixed the error message shown when a PID is not provided. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuperiorArri wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the error message shown when a PID is not provided. #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions procmap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#
# Thus, we obtain a full 'picture', a COMPLETE MEMORY MAP of the given process's
# VAS (Virtual Address Space)!
#
#
# Common terms:
# kva = kernel virtual address
# uva = user virtual address
Expand Down Expand Up @@ -376,7 +376,7 @@ XKERN_FILE=${XKERN_FILE}
done
shift $((OPTIND-1))

[[ ${PID} -eq 0 ]] && err 0 "Error: Invalid PID (must be a positive integer)"
[[ ${PID} -eq 0 ]] && err 0 "Specifying a valid PID with -p|--pid=<PID> is mandatory"
Copy link
Owner

@kaiwan kaiwan Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right; can you make the err msg as:
"Specifying a valid PID with -p <PID> or --pid=<PID> is mandatory"


LOG=log_procmap.txt
TMPCSV=/tmp/${name}/vgrph.csv
Expand Down