Skip to content

chore: mask metastore credentials in GraphConfig log output #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
em3s merged 2 commits into from
Sep 1, 2026
+19 −3
Merged

chore: mask metastore credentials in GraphConfig log output #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8358edb
chore: mask metastore credentials in GraphConfig log output
eazyhozy Aug 11, 2026
9f76cd0
refactor: redact credentials at the log call sites instead of in toSt…
eazyhozy Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions engine/src/main/kotlin/com/kakao/actionbase/v2/engine/Graph.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class Graph(
Mono.fromCallable {
printLog(config)

log.info("graph initialized with config: {}", config)
log.info("graph initialized with config: {}", config.redacted())
log.info("DEFAULT_BOUNDED_ELASTIC_SIZE: {}", Schedulers.DEFAULT_BOUNDED_ELASTIC_SIZE)
log.info("DEFAULT_BOUNDED_ELASTIC_QUEUESIZE: {}", Schedulers.DEFAULT_BOUNDED_ELASTIC_QUEUESIZE)

Expand Down Expand Up @@ -215,7 +215,7 @@ class Graph(
config.tenant,
config.phase,
)
log.info("graph initialized with config: {}", config)
log.info("graph initialized with config: {}", config.redacted())
log.info("DEFAULT_BOUNDED_ELASTIC_SIZE: {}", Schedulers.DEFAULT_BOUNDED_ELASTIC_SIZE)
log.info("DEFAULT_BOUNDED_ELASTIC_QUEUESIZE: {}", Schedulers.DEFAULT_BOUNDED_ELASTIC_QUEUESIZE)
}
Expand Down Expand Up @@ -929,7 +929,7 @@ class Graph(
DefaultStorageBackendFactory.initialize(config.hbase)
log.info("phase: {}", config.phase)
log.info("tenant: {}", config.tenant)
log.info("graph config: {}", config)
log.info("graph config: {}", config.redacted())
log.info("kafkaClientFactory: {}", kafkaClientFactory)
log.info("webClientFactory: {}", webClientFactory)

Expand Down
16 changes: 16 additions & 0 deletions engine/src/main/kotlin/com/kakao/actionbase/v2/engine/GraphConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,25 @@ data class GraphConfig(
val useJdbcMetastore: Boolean = true,
val featureFlags: List<FeatureFlags.Item> = emptyList(),
) {
/**
* A copy safe to log. The generated [toString] renders every field, so logging this config directly puts the
* metastore credentials in the log in plain text. Only the credentials are replaced - every other field stays
* visible, because that line is the primary record of how an instance was configured. An empty credential stays
* empty rather than masked, so "not configured" remains distinguishable from "configured".
*/
fun redacted(): GraphConfig =
copy(
metastoreUser = mask(metastoreUser),
metastorePassword = mask(metastorePassword),
)

companion object {
private const val MASK = "****"

val builder: Builder
get() = Builder()

private fun mask(credential: String): String = if (credential.isEmpty()) "" else MASK
}

class Builder {
Expand Down
Loading