Repository navigation
Fall back when the encoder buffer pool is exhausted - #506
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
When all pooled
EdgeBufferinstances are in use,borrow()getsnullfrompool.poll()and the next encode throws atreset(). Allocate a newEdgeBufferonly for that exhausted-pool case. This is the follow-up invited by the maintainer on #505.Why it matters
Concurrent encodes beyond
poolSizecan fail even though an independent buffer can encode the value.Review scope
Two
codec-javafiles: a fallback inAbstractEdgeEncoder.borrow()and one concurrency regression test. The pooled fast path and release behavior stay the same.Evidence
mainatafa7143f1d8a0d16623eb5de3e963706ff819bba, the regression reproduces the second encode'sNullPointerExceptionatuseAsByteArray:408.:codec-java:test: 68 passed;:codec-java:spotlessCheck: passed.:core:test --tests '*V2BulkLoadAggregationTest*': 1 passed.AI Assistance