feat: add regtest service profiles to node unlock command#17
Open
Arshia-r-m wants to merge 1 commit into
Open
Conversation
… supporting tests
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a selectable “Bitcoin services profile” to kaleido node unlock, including new regtest defaults, and verifies the behavior via CLI tests.
Changes:
- Introduces regtest default service constants (bitcoind/indexer/proxy) in config.
- Updates
node unlockinteractive flow to choose between signet defaults, regtest defaults, or fully custom values. - Adds CLI tests covering interactive signet defaults, regtest defaults, and custom service entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
kaleido_cli/config.py |
Adds regtest default service endpoints/credentials used by unlock profiles. |
kaleido_cli/commands/node.py |
Adds profile prompt + regtest defaults wiring into node unlock interactive prompts and help text. |
tests/conftest.py |
Extends RLN mock with unlock_wallet AsyncMock to support new command tests. |
tests/test_cmd_node.py |
Adds coverage for interactive unlock profile selection and custom overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.