Skip to content

feat: add channel fee estimation parameters and update related functions#9

Merged
Arshia-r-m merged 1 commit into
masterfrom
feat/bump-sdk-v0.1.3
Apr 8, 2026
Merged

feat: add channel fee estimation parameters and update related functions#9
Arshia-r-m merged 1 commit into
masterfrom
feat/bump-sdk-v0.1.3

Conversation

@Arshia-r-m
Copy link
Copy Markdown
Collaborator

No description provided.

@Arshia-r-m Arshia-r-m marked this pull request as ready for review April 7, 2026 17:16
Copilot AI review requested due to automatic review settings April 7, 2026 17:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CLI to align with kaleido-sdk==0.1.3, including new LSP channel fee estimation request/response models and updated trading-pair model types used by swap/market flows.

Changes:

  • Bump kaleido-sdk dependency from 0.1.2 to 0.1.3 (and refresh uv.lock accordingly).
  • Update trading-pair utilities to use TradableAssetResponseModel / TradingPairResponseModel and layer-specific asset-id resolution.
  • Rework channel order estimate-fees to call the new SDK fee-estimation API shape and introduce ChannelFeeEstimateParams; update node init prompts/help text.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
uv.lock Locks kaleido-sdk to 0.1.3 artifacts/hashes.
pyproject.toml Bumps kaleido-sdk pinned version to 0.1.3.
kaleido_cli/utils/pairs.py Adapts helpers to new SDK response-model types and asset id usage.
kaleido_cli/commands/node.py Improves wording for wallet password creation prompts/options.
kaleido_cli/commands/channel.py Adds fee-estimation params/model wiring and updates estimate-fees command/options/examples.
Comments suppressed due to low confidence (1)

kaleido_cli/commands/channel.py:905

  • channel order estimate-fees no longer accepts the positional client_pubkey argument. This is a breaking CLI change for any existing scripts that still pass a pubkey as the first argument. If the underlying API no longer needs it, consider keeping an optional/deprecated positional argument (ignored or validated) to preserve backward compatibility, or explicitly error when an unexpected argument is provided with a clear migration message.
)
def channel_estimate_fees(
    lsp_balance_sat: Annotated[
        int | None,
        typer.Option("--lsp-balance", help="LSP's balance in the channel (satoshis)."),
    ] = None,
    client_balance_sat: Annotated[

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +393 to +396
else:
lsp_asset_amount = None
client_asset_amount = None

Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In interactive mode, this branch resets lsp_asset_amount/client_asset_amount to None whenever asset_id is unset. If a user supplies --lsp-asset-amount/--client-asset-amount but forgets --asset-id, their explicit inputs get silently discarded (and the later validation won’t trigger). Consider detecting this case and either (a) prompting for --asset-id, or (b) failing fast with the same error used in non-interactive mode.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be done as enhancement in the future!

@bitwalt
Copy link
Copy Markdown
Collaborator

bitwalt commented Apr 8, 2026

LGTM

@Arshia-r-m Arshia-r-m merged commit e8711f1 into master Apr 8, 2026
5 checks passed
@Arshia-r-m Arshia-r-m deleted the feat/bump-sdk-v0.1.3 branch April 9, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants