fix: make language switcher reachable in mobile menu#41
Merged
Conversation
The mobile nav menu is `position: fixed`, but `div.animate-fadeIn` (wraps the whole app) keeps a `transform` after its intro animation, making it the containing block for fixed descendants. The menu was therefore sized to the full document instead of the viewport — it could not scroll, so the language switcher and its dropdown fell off-screen. - Navbar: portal the mobile menu to `document.body` so `fixed` resolves against the viewport; give it an explicit `h-[calc(100dvh-4rem)]`. - LanguageSwitcher: scroll the dropdown into view when it opens so its options are visible inside the scrollable mobile menu. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
website | 6e2aa62 | Commit Preview URL Branch Preview URL |
May 16 2026, 02:44 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On mobile, the language switcher could not be used: the full-screen nav menu (
position: fixed) was trapped bydiv.animate-fadeIn, which keeps atransformafter its intro animation and so becomes the containing block forfixeddescendants. The menu was sized to the whole document (~8000px) instead of the viewport, could not scroll, and the language dropdown fell off-screen.document.bodysofixedresolves against the viewport; add an explicith-[calc(100dvh-4rem)].Test plan
🤖 Generated with Claude Code