[codex] Prepare auth signing for Protocol 27#11
Draft
kalepail wants to merge 4 commits into
Draft
Conversation
74371ff to
d27c276
Compare
Owner
Author
|
Initial review follow-up: The first review found two issues that are now addressed:
Validation after this fix:
|
d27c276 to
b920c5f
Compare
Owner
Author
|
Protocol 27 hardening follow-up: Additional review found and fixed several compatibility and migration concerns:
Deferred intentionally:
Validation:
|
b920c5f to
6945546
Compare
Owner
Author
|
Expiration normalization follow-up: A related Protocol 27 auth review highlighted that fallback signature expiration ledgers can become fractional before XDR serialization. This PR now applies the same hardening:
Validation:
|
6945546 to
174fb73
Compare
Owner
Author
|
Final Protocol 27 auth review summary: The PR matches the intended Protocol 27 auth split:
Additional coverage added:
Validation:
|
Owner
Author
|
Stellar SDK v16 RC validation update:
Validation:
|
Owner
Author
|
Additional RC readiness pass:
Validation:
|
Owner
Author
|
Adversarial review follow-up:
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@stellar/stellar-sdk@16.0.0-rc.1.@stellar/stellar-sdk@16.0.0-rc.1in the package peer ranges for RC consumers.buildAuthorizationEntryPreimage()helper when available, while preserving the fallback behavior for older SDKs.credentials().address().@stellar/stellar-basedependency and align the demo with the v16 RC package layout.Context
Protocol 27 / CAP-0071 adds address-bound Soroban auth payloads via
ENVELOPE_TYPE_SOROBAN_AUTHORIZATION_WITH_ADDRESSand introduces ADDRESS_V2 plus ADDRESS_WITH_DELEGATES credential types. Legacy ADDRESS remains valid during Protocol 27, but clients that inspect or sign auth entries should stop assuming every address credential uses the legacy arm.The v16.0.0 RC of the Stellar JS SDK now exposes the relevant Protocol 27 auth surface, including regenerated CAP-71 XDR,
buildAuthorizationEntryPreimage(), andbuildWithDelegatesEntry(). This PR now validates against that RC directly and compares the kit's generated auth preimages with the SDK helper for legacy ADDRESS, ADDRESS_V2, and ADDRESS_WITH_DELEGATES entries.Validation
pnpm installpnpm exec tsc --noEmit --pretty falsepnpm test --runpnpm run buildpnpm run build:demo