ILMS-95 - hide grader info from student for kalvidassignment#393
Open
hilak wants to merge 1 commit into
Open
Conversation
hilak
commented
Jan 10, 2023
| } | ||
|
|
||
| // Kalvidassign savepoint reached. | ||
| upgrade_mod_savepoint(true, 2014023000.01, 'kalvidassign'); |
Contributor
Author
There was a problem hiding this comment.
@gonenradai do you know what the value for this savepoint should be?
Contributor
There was a problem hiding this comment.
I think this is some indication of the "version" of the DB schema of the module.
That way, if a module needs to update the schema, it can compare the last known save point that is written in the DB and know which steps to perform (for example, if the upgrade is jumping few versions and needs multiple ALTER calls) to upgrade to the latest schema.
Contributor
There was a problem hiding this comment.
I think the value you want to save is the new version that you're comparing against - 2022041905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.