Skip to content

SUP-42220 fix grade string reference#466

Merged
roileviK merged 3 commits into
MOODLE_405_DEVfrom
SUP-42220-Incorrect-text-appearing-on-Moodle-grade-view-4.5
Jul 22, 2025
Merged

SUP-42220 fix grade string reference#466
roileviK merged 3 commits into
MOODLE_405_DEVfrom
SUP-42220-Incorrect-text-appearing-on-Moodle-grade-view-4.5

Conversation

@roileviK
Copy link
Copy Markdown
Contributor

No description provided.

@roileviK roileviK requested review from alon1980 and muli July 20, 2025 12:02
@lucaboesch
Copy link
Copy Markdown
Contributor

lucaboesch commented Jul 20, 2025

This is not a wise fix, re-adding a string that's in core.
Note there is now a distinction of grade as verb and grade as noun.
You would be re-introducing the non-distinction flaw.
Use the approach from #434 using the core string instead which is sustainable.

@roileviK roileviK changed the title KMS-42220 fix grade string reference - add kalvidassign component KMS-42220 fix grade string reference Jul 20, 2025
@roileviK roileviK changed the title KMS-42220 fix grade string reference SUP-42220 fix grade string reference Jul 20, 2025
Copy link
Copy Markdown
Contributor

@lucaboesch lucaboesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @roileviK

@roileviK roileviK merged commit 37d4a1d into MOODLE_405_DEV Jul 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants