Skip to content

Sup 42220 incorrect text appearing on moodle grade view 4.4 #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roileviK merged 2 commits into from
Jul 22, 2025
Merged

Sup 42220 incorrect text appearing on moodle grade view 4.4 #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fd9acb
SUP-42220 remove deprecated grade string
roileviK Jul 22, 2025
b759cf2
SUP-42220 use updated gradeverb and gradenoun core moodle strings
roileviK Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mod/kalvidassign/lang/en/kalvidassign.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
$string['emptyentryid'] = 'Video assignment was not submitted correctly. Please try to resubmit.';
$string['deleteallsubmissions'] = 'Delete all video submissions';
$string['fullname'] = 'Name';
$string['grade'] = 'Grade';
$string['submissioncomment'] = 'Comment';
$string['timemodified'] = 'Last modified (Submission)';
$string['grademodified'] = 'Last modified (Grade)';
Expand Down
8 changes: 4 additions & 4 deletions mod/kalvidassign/renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ public function col_status($data) {
$buttontext = get_string('update');
} else {
$class = 's0';
$buttontext = get_string('grade');
$buttontext = get_string('gradeverb');
}

if (!$submitted) {
Expand Down Expand Up @@ -873,7 +873,7 @@ public function display_submissions_table($cm, $groupfilter = 0, $filter = 'all'
$baseurl = new moodle_url('/mod/kalvidassign/grade_submissions.php', array('cmid' => $cm->id));

$col1 = get_string('fullname', 'kalvidassign');
$col2 = get_string('grade', 'kalvidassign');
$col2 = get_string('gradenoun');
$col3 = get_string('submissioncomment', 'kalvidassign');
$col4 = get_string('timemodified', 'kalvidassign');
$col5 = get_string('grademodified', 'kalvidassign');
Expand Down Expand Up @@ -1126,7 +1126,7 @@ public function display_grade_feedback($kalvidassign, $context) {
echo '<td class="left side">&nbsp;</td>';
echo '<td class="content">';
echo '<div class="grade">';
echo get_string("grade").': '.$grade->str_long_grade;
echo get_string('gradenoun').': '.$grade->str_long_grade;
echo '</div>';
echo '<div class="clearer"></div>';

Expand All @@ -1149,7 +1149,7 @@ public function render_kalvidassign_course_index_summary(kalvidassign_course_ind
$strsectionname = $indexsummary->courseformatname;
$strduedate = get_string('duedate', 'kalvidassign');
$strsubmission = get_string('submission', 'kalvidassign');
$strgrade = get_string('grade');
$strgrade = get_string('gradenoun');

$table = new html_table();
if ($indexsummary->usesections) {
Expand Down
2 changes: 1 addition & 1 deletion mod/kalvidassign/single_submission_form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function definition() {
$grademenu = make_grades_menu($this->_customdata->cminstance->grade);
$grademenu['-1'] = get_string('nograde');

$mform->addElement('select', 'xgrade', get_string('grade').':', $grademenu, $attributes);
$mform->addElement('select', 'xgrade', get_string('gradenoun').':', $grademenu, $attributes);

if (isset($submission->grade)) {
$mform->setDefault('xgrade', $this->_customdata->submission->grade );
Expand Down