Skip to content

Replace removed assertObjectHasAttribute() with assertObjectHasProperty() #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctam wants to merge 1 commit into
base: MOODLE_501_DEV
Choose a base branch
from
+39 −39
Open

Replace removed assertObjectHasAttribute() with assertObjectHasProperty() #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions local/kaltura/tests/locallib_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,21 +716,21 @@ public function test_local_kaltura_format_lti_instance_object() {

$result = local_kaltura_format_lti_instance_object($param);

$this->assertObjectHasAttribute('course', $result);
$this->assertObjectHasAttribute('id', $result);
$this->assertObjectHasAttribute('name', $result);
$this->assertObjectHasAttribute('intro', $result);
$this->assertObjectHasAttribute('instructorchoicesendname', $result);
$this->assertObjectHasAttribute('instructorchoicesendemailaddr', $result);
$this->assertObjectHasAttribute('instructorcustomparameters', $result);
$this->assertObjectHasAttribute('instructorchoiceacceptgrades', $result);
$this->assertObjectHasAttribute('instructorchoiceallowroster', $result);
$this->assertObjectHasAttribute('resourcekey', $result);
$this->assertObjectHasAttribute('password', $result);
$this->assertObjectHasAttribute('toolurl', $result);
$this->assertObjectHasAttribute('securetool', $result);
$this->assertObjectHasAttribute('forcessl', $result);
$this->assertObjectHasAttribute('cmid', $result);
$this->assertObjectHasProperty('course', $result);
$this->assertObjectHasProperty('id', $result);
$this->assertObjectHasProperty('name', $result);
$this->assertObjectHasProperty('intro', $result);
$this->assertObjectHasProperty('instructorchoicesendname', $result);
$this->assertObjectHasProperty('instructorchoicesendemailaddr', $result);
$this->assertObjectHasProperty('instructorcustomparameters', $result);
$this->assertObjectHasProperty('instructorchoiceacceptgrades', $result);
$this->assertObjectHasProperty('instructorchoiceallowroster', $result);
$this->assertObjectHasProperty('resourcekey', $result);
$this->assertObjectHasProperty('password', $result);
$this->assertObjectHasProperty('toolurl', $result);
$this->assertObjectHasProperty('securetool', $result);
$this->assertObjectHasProperty('forcessl', $result);
$this->assertObjectHasProperty('cmid', $result);

$this->assertEquals(1, $result->course);
$this->assertEquals(1, $result->id);
Expand Down Expand Up @@ -846,43 +846,43 @@ public function test_local_kaltura_log_data_logging_request_data() {
$this->assertTrue($result);
$record = $DB->get_record('local_kaltura_log', array('module'=> 'mymedia'));

$this->assertObjectHasAttribute('id', $record);
$this->assertObjectHasProperty('id', $record);

$this->assertObjectHasAttribute('module', $record);
$this->assertObjectHasProperty('module', $record);
$this->assertEquals(KAF_MYMEDIA_MODULE, $record->module);

$this->assertObjectHasAttribute('type', $record);
$this->assertObjectHasProperty('type', $record);
$this->assertEquals(KALTURA_LOG_REQUEST, $record->type);

$this->assertObjectHasAttribute('endpoint', $record);
$this->assertObjectHasProperty('endpoint', $record);
$this->assertEquals('http://localhost', $record->endpoint);

$this->assertObjectHasAttribute('data', $record);
$this->assertObjectHasProperty('data', $record);
$this->assertEquals(serialize($data), $record->data);

$this->assertObjectHasAttribute('timecreated', $record);
$this->assertObjectHasProperty('timecreated', $record);
$this->assertNotEquals(0, $record);

$result = local_kaltura_log_data(KAF_MEDIAGALLERY_MODULE, 'http://localhost', $data, true);
$this->assertTrue($result);

$record = $DB->get_record('local_kaltura_log', array('module'=> 'coursegallery'));

$this->assertObjectHasAttribute('id', $record);
$this->assertObjectHasProperty('id', $record);

$this->assertObjectHasAttribute('module', $record);
$this->assertObjectHasProperty('module', $record);
$this->assertEquals(KAF_MEDIAGALLERY_MODULE, $record->module);

$this->assertObjectHasAttribute('type', $record);
$this->assertObjectHasProperty('type', $record);
$this->assertEquals(KALTURA_LOG_REQUEST, $record->type);

$this->assertObjectHasAttribute('endpoint', $record);
$this->assertObjectHasProperty('endpoint', $record);
$this->assertEquals('http://localhost', $record->endpoint);

$this->assertObjectHasAttribute('data', $record);
$this->assertObjectHasProperty('data', $record);
$this->assertEquals(serialize($data), $record->data);

$this->assertObjectHasAttribute('timecreated', $record);
$this->assertObjectHasProperty('timecreated', $record);
$this->assertNotEquals(0, $record);
}

Expand All @@ -905,21 +905,21 @@ public function test_local_kaltura_log_data_logging_response_data() {

$record = $DB->get_record('local_kaltura_log', array('module'=> 'phpunit response'));

$this->assertObjectHasAttribute('id', $record);
$this->assertObjectHasProperty('id', $record);

$this->assertObjectHasAttribute('module', $record);
$this->assertObjectHasProperty('module', $record);
$this->assertEquals('phpunit response', $record->module);

$this->assertObjectHasAttribute('type', $record);
$this->assertObjectHasProperty('type', $record);
$this->assertEquals(KALTURA_LOG_RESPONSE, $record->type);

$this->assertObjectHasAttribute('endpoint', $record);
$this->assertObjectHasProperty('endpoint', $record);
$this->assertEquals('http://localhost', $record->endpoint);

$this->assertObjectHasAttribute('data', $record);
$this->assertObjectHasProperty('data', $record);
$this->assertEquals(serialize($data), $record->data);

$this->assertObjectHasAttribute('timecreated', $record);
$this->assertObjectHasProperty('timecreated', $record);
$this->assertNotEquals(0, $record);
}

Expand Down
12 changes: 6 additions & 6 deletions local/kaltura/tests/migrationlib_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ public function test_initialization_of_config_values() {

$configsettings = get_config(KALTURA_PLUGIN_NAME);

$this->assertObjectHasAttribute('migrationstarted', $configsettings);
$this->assertObjectHasAttribute('existingcategoryrun', $configsettings);
$this->assertObjectHasAttribute('sharedcategoryrun', $configsettings);
$this->assertObjectHasAttribute('categoriescreated', $configsettings);
$this->assertObjectHasAttribute('entriesmigrated', $configsettings);
$this->assertObjectHasAttribute('kafcategoryrootid', $configsettings);
$this->assertObjectHasProperty('migrationstarted', $configsettings);
$this->assertObjectHasProperty('existingcategoryrun', $configsettings);
$this->assertObjectHasProperty('sharedcategoryrun', $configsettings);
$this->assertObjectHasProperty('categoriescreated', $configsettings);
$this->assertObjectHasProperty('entriesmigrated', $configsettings);
$this->assertObjectHasProperty('kafcategoryrootid', $configsettings);
$this->assertEquals(0, $configsettings->migrationstarted);
$this->assertEquals(0, $configsettings->existingcategoryrun);
$this->assertEquals(0, $configsettings->sharedcategoryrun);
Expand Down