Checklist:
Adheres to PEP-8 formatting (or consistent and explained when deviating)
Yes! This looks pretty close to perfect to me! I suspect there are a few lines that are over 80 characters, and the starttime function should probably be start_time. I think there should also be a docstring at the top explaining the code function. Other than that this looks great!
Commit history that reflects small and frequent commits since project assignment
Yes
Clear installation instructions, installation tested if available
Yes, seamless.
Current version number (note the current version number)
I don't see this written anywhere, I assume v1.0.0?
Example problem with required data either provided or with a data fetching script
No, but since this is a game I don't think it's appropriate.
Appropriate use of functions, tasks are broken into logical chunks
Yes
Readability, organization, accessibility: Code is well-commented where necessary, files are organized in a logical manner, naming is intuitive or explanatory
Yes, very
Documentation is explanative of: what, why, how
Could use a docstring at the start of game.py, but the README.md file provides good information
Task #1 Selected (note which task is selected)
Implementing classes
Task #2 Selected (note which task is selected)
Implementing user input and branching development
What does this code do?
This code opens a game window where you can move around a firefighter to dodge falling flames. Once you hit a flame, the game ends. As time goes on, more and more flames are added and the difficulty increases. I cant get past 50 seconds :(
How does this code do it?
It uses OOP and defines classes for the game as a whole, the avatar and the fire. The main function sets up a while loop that updates the game 60 times a second and handles the left/right arrow input.
What data does this code work with?
The background, avatar, and fire all all .png files.
What do you find cool/interesting/unique about this code?
I'm so impressed by the functionality! What a cute idea I hope your boyfriend likes it. I had to look it up, but I think using pygame mask is really cool. It makes it feel like a much more legit game.
How can this code be improved (e.g., restructuring, optimization, improved examples, clearer explanation? - provide some input into how you could implement that)
I don't have any complaints expect added features that I think you are working on in the development branch (ie putting out the fire with water. It could also be cool to have some fires in the windows and require the user to climb a ladder to put them out.
Checklist:
Adheres to PEP-8 formatting (or consistent and explained when deviating)
Yes! This looks pretty close to perfect to me! I suspect there are a few lines that are over 80 characters, and the starttime function should probably be start_time. I think there should also be a docstring at the top explaining the code function. Other than that this looks great!
Commit history that reflects small and frequent commits since project assignment
Yes
Clear installation instructions, installation tested if available
Yes, seamless.
Current version number (note the current version number)
I don't see this written anywhere, I assume v1.0.0?
Example problem with required data either provided or with a data fetching script
No, but since this is a game I don't think it's appropriate.
Appropriate use of functions, tasks are broken into logical chunks
Yes
Readability, organization, accessibility: Code is well-commented where necessary, files are organized in a logical manner, naming is intuitive or explanatory
Yes, very
Documentation is explanative of: what, why, how
Could use a docstring at the start of game.py, but the README.md file provides good information
Task #1 Selected (note which task is selected)
Implementing classes
Task #2 Selected (note which task is selected)
Implementing user input and branching development
What does this code do?
This code opens a game window where you can move around a firefighter to dodge falling flames. Once you hit a flame, the game ends. As time goes on, more and more flames are added and the difficulty increases. I cant get past 50 seconds :(
How does this code do it?
It uses OOP and defines classes for the game as a whole, the avatar and the fire. The main function sets up a while loop that updates the game 60 times a second and handles the left/right arrow input.
What data does this code work with?
The background, avatar, and fire all all .png files.
What do you find cool/interesting/unique about this code?
I'm so impressed by the functionality! What a cute idea I hope your boyfriend likes it. I had to look it up, but I think using pygame mask is really cool. It makes it feel like a much more legit game.
How can this code be improved (e.g., restructuring, optimization, improved examples, clearer explanation? - provide some input into how you could implement that)
I don't have any complaints expect added features that I think you are working on in the development branch (ie putting out the fire with water. It could also be cool to have some fires in the windows and require the user to climb a ladder to put them out.