recover ActionSet stuck in running phase after controller restart#3971
Open
abdul-saqib wants to merge 2 commits intomasterfrom
Open
recover ActionSet stuck in running phase after controller restart#3971abdul-saqib wants to merge 2 commits intomasterfrom
abdul-saqib wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Abdul Saqib <s.abdul@veeam.com>
Signed-off-by: Abdul Saqib <s.abdul@veeam.com>
abdul-saqib
force-pushed
the
bugfix/ActionSet-stuck-running
branch
from
7eac17c to
96e306a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Overview
Problem
When the Kanister controller restarted (e.g. due to OOMKill) while an ActionSet was executing, the ActionSet would remain stuck in the
runningphase indefinitely.Solution
Introduce
handleRunningActionSetwhich is called on startup for any ActionSet found inrunningstate. If all phases are already complete it transitions the ActionSet tocompleteotherwise it transitions tofailedwith a clear error message prompting the user to retry.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan