Skip to content

Add extra transactiontypes - #507

Open
antmcmullen wants to merge 81 commits into
kantorge:developfrom
antmcmullen:add_extra_transactiontypes
Open

Add extra transactiontypes#507
antmcmullen wants to merge 81 commits into
kantorge:developfrom
antmcmullen:add_extra_transactiontypes

Conversation

@antmcmullen

@antmcmullen antmcmullen commented Jul 16, 2026

Copy link
Copy Markdown

This change brings in 3 new Investment Cost categories to match that of actual scenarios i have encountered.

  1. Product Fee, I encounter a monthly fee which i want to attribute to the assets that are under management by that company as they are very much only a charge because they exist, as such I may have no dividend or other transaction to account for. hence a new category of Product Fee
    2)Purchased Interest, In the corporate bond markets if you buy out of cycle the interest payments, the existing bond holder expects to be compensated for accrued interest, which materialises as a negative dividend payment (which hopefully you recover on the next dividend cycle!) This purchased interest mirrors the usage of dividend just with a reversed cashflow
  2. Tax_relief, when in the UK investing into EIS or SEIS schemes, you receive a tax credit, i find it more useful to attribute this to the investments so i can understand impacts on when a company ceases to trade, has a HMRC event, or a positive exit occurs ( I ledger this against a HMRC reserve account which i deal with separately)

Summary by CodeRabbit

  • Documentation
    • Added the 3.4.0 release entry to the changelog.
    • Refreshed historical changelog formatting and links.
  • New Features
    • Added support for configurable decimal separators in web-scraped investment prices.
    • Included updates covering dark mode and AI-related documentation.
  • Chores
    • Updated the application and package version to 3.4.0.

kantorge and others added 30 commits January 11, 2025 18:46
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

Release metadata was updated to version 3.4.0, a new 3.4.0 changelog entry was added, and historical changelog entries were regenerated with consistent formatting and links.

Changes

3.4.0 release updates

Layer / File(s) Summary
Version metadata and new release entry
.release-please-manifest.json, composer.json, CHANGELOG.md
Package version fields were updated to 3.4.0, and the changelog gained categorized entries for the 3.4.0 release.
Historical changelog regeneration
CHANGELOG.md
Recent and older release entries were refreshed with consistent categories, bullets, links, and formatting.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change by describing the addition of extra transaction types, despite the noisy parenthetical.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

	modified:   app/Http/Requests/TransactionRequest.php
	modified:   app/Services/TransactionService.php
	new file:   database/migrations/2026_07_16_000001_add_missing_transaction_types_to_transactions_enum.php
	modified:   resources/js/shared/lib/datatable/index.js
	modified:   resources/js/transactions/components/form/TransactionFormInvestment.vue
	modified:   tests/Feature/API/TransactionApiControllerTest.php
	modified:   tests/Unit/Services/TransactionServiceTest.php
@antmcmullen antmcmullen changed the title Add extra transactiontypes Add extra transactiontypes (REJECT ME) Jul 16, 2026
@antmcmullen antmcmullen changed the title Add extra transactiontypes (REJECT ME) Add extra transactiontypes Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants