Add extra transactiontypes - #507
Open
antmcmullen wants to merge 81 commits into
Open
Conversation
…s--main chore(main): release 1.13.0
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s--main chore(main): release 1.13.2
…s--main chore(main): release 1.13.3
…s--main chore(main): release 1.13.4
…s--main chore(main): release 1.13.5
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s--main chore(main): release 2.2.0
…s--main chore(main): release 2.3.0
* chore(main): release 2.3.1
…s--main chore(main): release 3.0.2
|
Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughWalkthroughRelease metadata was updated to version 3.4.0, a new 3.4.0 changelog entry was added, and historical changelog entries were regenerated with consistent formatting and links. Changes3.4.0 release updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
modified: app/Http/Requests/TransactionRequest.php modified: app/Services/TransactionService.php new file: database/migrations/2026_07_16_000001_add_missing_transaction_types_to_transactions_enum.php modified: resources/js/shared/lib/datatable/index.js modified: resources/js/transactions/components/form/TransactionFormInvestment.vue modified: tests/Feature/API/TransactionApiControllerTest.php modified: tests/Unit/Services/TransactionServiceTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings in 3 new Investment Cost categories to match that of actual scenarios i have encountered.
2)Purchased Interest, In the corporate bond markets if you buy out of cycle the interest payments, the existing bond holder expects to be compensated for accrued interest, which materialises as a negative dividend payment (which hopefully you recover on the next dividend cycle!) This purchased interest mirrors the usage of dividend just with a reversed cashflow
Summary by CodeRabbit