[karatektus]

Closes #135

Takes over #123 by @Flouss, whose fork was archived, so that branch can no longer be pushed to. All their commits are kept. Squash-merge with Co-authored-by: Flouss.

Changes on top of #123

• Migration Version20261015130000 for drafts stored before the upgrade, which fix(sync): a draft synced from Outlook or Gmail opens in the editor, and one sent elsewhere stops being a draft #123 left at a 404. It clears sent_at only on rows flagged \Draft that the provider still files as drafts: Gmail DRAFT without SENT, Graph's Drafts label without Sent. A stored draft that was sent elsewhere before the upgrade keeps its sent_at, so it can't become sendable a second time. IMAP rows aren't touched (their flag is Draft, which isDraft() doesn't read as a draft). Threads aren't re-ranked. down() is a no-op.
  SyncedDraftSentAtMigrationTest runs it against rows: six cases, each "cleared" with a "kept" partner. Mutation-checked: without the narrowing, the three kept cases fail.
• Merged main. GraphDraftSentElsewhereTest now builds GraphApiSyncer with the two arguments main added since (ThreadLabelSynchronizer, SyncNotifier). Without them PHPStan and the test failed.
• CHANGELOG: says what the migration does, and credits this PR.
• On top of fix(push): the installed app says New mail only when mail arrived #162 (now merged): its guard records a Graph re-report only when the folder changed. A draft filed in Sent Items before settling existed still wears \Draft, and its re-report is where it settles. That is now counted as a change, so it's recorded for JMAP clients and the open list refreshes. Tested in GraphDraftSentElsewhereTest::testADraftAlreadyFiledInSentIsSettledAndRecordedOnItsReReport (fails without the change).

How it was checked

• PHPStan: no errors.
• PHPUnit, 1,754 tests (ComposeSafety, Domain, Entity/Mail, Messaging handlers, Gmail, Graph, Imap, Service/Mail, Migrations, Documentation, Translation): green.

Left as is

• A draft sent from Gmail, or moved into Sent Items under immutable ids, is settled with the time it was noticed (now), not the provider's send time. That only affects the sort time of a draft stored after this change.

#123's own description:

Problem

A draft that arrives by sync (Outlook or Gmail) is listed in its conversation, but clicking it gives a 404: ComposeController::assertEditableDraft (the guard that only lets an unsent draft open) refuses anything with a sentAt, and every sync builder sets sentAt on a draft:

• Graph: sentAt = sentDateTime ?? receivedDateTime, and Outlook gives a draft a receivedDateTime but no sentDateTime.
• Gmail: sentAt = receivedAt from internalDate.
• IMAP: sentAt = receivedAt from the Date header.

Change

• The builders leave sentAt null for a draft, the same state a draft written in plMail has (receivedAt is unchanged). Documented on Message::$sentAt. The IMAP builder decides from the stored flag via isDraft(); webklex strips the backslash, so a real server's \Draft is stored as Draft and is not a draft to the app yet. That part does nothing until the flags are canonicalised at ingest, and is deliberately kept consistent with isDraft() instead.
• ReadReceiptPolicy::decide recognised our own mail by sentAt; it checks the draft flag as well now.

sentAt was also quietly protecting the other direction, which this PR has to handle: sync stores a draft once and never rebuilds a stored row, so a draft sent from another client stayed \Draft with no sentAt and would now open in the editor, be sendable a second time, and discarding it would delete the sent copy at the provider. Message::settleAsSent() is the one place that says what "was sent" means for a stored draft (flag off, keep an existing sentAt else now, thread ranked by it, never backwards). It is called when

• Graph files a stored message in Sent Items (same id, immutable ids),
• the Graph batch handler re-points a stored message whose fetched resource says isDraft: false (new id, no immutable ids; an absent key is not an answer),
• Gmail enrichment re-reads a stored draft whose labels have SENT and no DRAFT.

Trash and Drafts do not settle.

RemoteFlagState::storedFlags() rebuilt Gmail's and Graph's flag mirror from read and starred alone, which dropped \Draft the first time a stored draft was re-read, although the refresh's own comment says it survives. It now carries the flag over. This touches the shared flag refresh, so it deserves a look.

Notes

• Visible side effect (in the changelog): a conversation holding a synced draft is no longer moved up the list by the draft's date, the same as for a draft written in plMail.
• Drafts already stored are not migrated; their sent_at has to be cleared once (a single UPDATE on the affected rows).
• The send-elsewhere behaviour rests on two assumptions about the providers that the tests encode but that I have not observed against live Outlook or Gmail: Graph either keeps the id or re-fetches the sent copy with isDraft: false, and Gmail keeps the message id with DRAFT replaced by SENT.

Tests

Builder tests for all three providers, the sent-elsewhere paths (Graph same id, Graph new id, Gmail) each with a companion that must stay a draft, the settle method, the flag mirror, the editor opening a synced draft and still refusing a received mail, and the read-receipt guard. Each behaviour was broken on purpose and the test written for it failed. Full suite green except IntegrationUrlValidatorTest (container cannot resolve localhost.); phpstan clean on the changed files.

🤖 Generated with Claude Code

🤖 Generated with Claude Code