Repository navigation
linked-issue: read the description of a pull request into a milestone branch - #255
Merged
Merged
Conversation
… branch (#254) GitHub links an issue from "Closes #N" only in a pull request into the default branch. Into milestone/v0.3.8 or a wip/ branch the closing references stay empty, so the check failed on every such pull request however its description named the issue (#252 was the first). For a pull request into another branch, the description is now read for the same keywords GitHub accepts. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 894c7f6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
linked-issuefails on every PR intomilestone/**orwip/**, even when its description saysCloses #N, because GitHub only links an issue from a PR into the default branch. #252 intomilestone/v0.3.8is failing on it right now.This is the same commit as #254, which went into
milestone/v0.3.8. It can only work from here: GitHub runs apull_request_targetworkflow as it is on the default branch, whatever the PR's base, so the copy on the milestone branch is never run. #254's description said otherwise, and that was wrong. Both copies are identical, so the milestone branch merges cleanly once this is in.Fix: if the base isn't the default branch and nothing is linked, the description is checked for the keywords GitHub accepts (
close[sd],fix(e[sd]),resolve[sd]followed by#N). The description goes in throughenv, never into the script. PRs intomainbehave exactly as before.🤖 Generated with Claude Code