Repository navigation
Publish an image for every push to a milestone branch - #261
Merged
Merged
Conversation
A milestone branch collects a release before it reaches main, and nothing built it, so an install could not run that release until it was merged. docker.yml now builds pushes to milestone/** the way it builds main: amd64, tagged with the branch name (milestone-v0.3.8) and sha-..., never latest and never the catalogue. The tag is in the upgrading page's table, in both languages, and in the changelog's note on image tags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker.ymlbuiltmainandv*tags and nothing else, somilestone/v0.3.8(#250) had no image an install could run. This addsmilestone/**to the push trigger.mainpush. It builds amd64 only and is tagged with the branch name. The metadata action turnsmilestone/v0.3.8intomilestone-v0.3.8, plussha-<commit>.latest, touch the TrueNAS catalogue, or publish a GitHub Release. Those are gated onrefs/tags/vin the workflow, and this change doesn't affect them.docs/install/upgrading.mdand its German page (hash updated), with the warning that a milestone image can carry migrationsmaindoesn't have yet. The changelog's note on image tags mentions it too.A push runs the workflow file of the commit being pushed. So
milestone/v0.3.8only starts publishing oncemainwith this change has been merged into it. I'll do that merge right after this PR lands.🤖 Generated with Claude Code