Fix HTML entity double-encoding and display issues #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where special characters like apostrophes were being stored and displayed as double or triple-encoded HTML entities (e.g., ' instead of '). Backend Changes: - Update sanitize_input in dive_routes.py to unescape text before escaping it. This makes the operation idempotent and prevents the double-encoding cycle during repeated saves. Frontend Changes: - Implement recursive decoding in htmlDecode.js (up to 3 passes) to properly handle legacy triple-encoded data from the database. - Update multiple React components (Admin tables, search inputs, previews, and edit forms) to decode HTML entities before rendering via JSX. This ensures correct visual display while relying on React's native escaping for XSS protection. - Fix a pre-existing XSS vulnerability in DiveDetail.js by removing explicit decoding from Leaflet map popup template strings. These now leverage the browser's native entity decoding in innerHTML, which is safe from script injection.
kargig
force-pushed
the
decodehtml_improvements
branch
from
3a13e1e to
74fea7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where special characters like apostrophes were being stored and displayed as double or triple-encoded HTML entities (e.g., ' instead of ').
Backend Changes:
Frontend Changes: