Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .idea/AndroidProjectSystem.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions .idea/deploymentTargetSelector.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions .idea/migrations.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions .idea/runConfigurations.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 12 additions & 3 deletions app/src/main/java/edu/temple/namelist/CustomAdapter.kt
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,20 @@ import android.widget.TextView
class CustomAdapter(private val names: List<String>, private val context: Context) : BaseAdapter() {

// How many items are in the collection
override fun getCount(): Int {
return 5
}

// this is a bug because its hard coded to 5
// override fun getCount(): Int {
// return 5
// }

// fixed using ref instead of set val
// ret dynamize size list
override fun getCount(): Int = names.size

// Fetch an item from the collection


// i assume p0 mean position, maybe refactor is good but i didn't touch the code.
override fun getItem(p0: Int): Any {
return names[p0]
}
Expand Down
17 changes: 15 additions & 2 deletions app/src/main/java/edu/temple/namelist/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,25 @@ class MainActivity : AppCompatActivity() {

override fun onNothingSelected(p0: AdapterView<*>?) {
}

}
}

// this crash when we press delete while having no object left

// findViewById<View>(R.id.deleteButton).setOnClickListener {
// (names as MutableList).removeAt(spinner.selectedItemPosition)
// (spinner.adapter as BaseAdapter).notifyDataSetChanged()
// }


// my code remove base on pos, where pos is checked first to prevent the bug
findViewById<View>(R.id.deleteButton).setOnClickListener {
(names as MutableList).removeAt(spinner.selectedItemPosition)
(spinner.adapter as BaseAdapter).notifyDataSetChanged()
val pos = spinner.selectedItemPosition
if (pos >= 0 && pos < names.size) {
(names as MutableList).removeAt(pos)
(spinner.adapter as BaseAdapter).notifyDataSetChanged()
}
}

}
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
plugins {
id("com.android.application") version "8.6.1" apply false
id("com.android.application") version "8.13.2" apply false
id("org.jetbrains.kotlin.android") version "1.9.0" apply false
}
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Mon Oct 16 12:22:02 EDT 2023
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists