Skip to content

BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x, too#286

Open
jdforrester wants to merge 1 commit intokarma-runner:masterfrom
jdforrester:grunt-peer
Open

BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x, too#286
jdforrester wants to merge 1 commit intokarma-runner:masterfrom
jdforrester:grunt-peer

Conversation

@jdforrester
Copy link
Copy Markdown
Contributor

@jdforrester jdforrester commented Apr 14, 2020

Note that this is a breaking change (in the name of user security, but still).

johnjbarton
johnjbarton suggested changes Apr 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark as BREAKING CHANGE per https://www.conventionalcommits.org/en/v1.0.0-beta.2/

@jdforrester jdforrester changed the title chore(deps): raise grunt peerDependency to 1.1.x too BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x, too Apr 14, 2020
@jginsburgn
Copy link
Copy Markdown

jginsburgn commented May 12, 2021

@jdforrester Please fix the commitlint errors:

⧗   input: BREAKING CHANGE: chore(deps): raise grunt peerDependency to 1.1.x too
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@johnjbarton johnjbarton johnjbarton requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jdforrester jdforrester

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdforrester @jginsburgn @johnjbarton