Conversation
heemankv
force-pushed
the
perf/pedersen-cache-runtime-config
branch
2 times, most recently
from
August 31, 2026 17:26
25ca4d2 to
454d432
Compare
heemankv
force-pushed
the
perf/pedersen-cache-runtime-config
branch
from
August 31, 2026 17:54
454d432 to
76dec03
Compare
Mohiiit
reviewed
Sep 1, 2026
Mohiiit
left a comment
There was a problem hiding this comment.
I didn't find a merge-blocking Rust correctness issue at this head. I left two non-blocking questions inline.
Mohiiit
approved these changes
Sep 1, 2026
Mohiiit
left a comment
There was a problem hiding this comment.
The two review questions are addressed at this head, and I didn't find additional blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/pedersen_cache.rs;runtime.rsonly performs cache lookup and insertion around the Pedersen callset_pedersen_cache_enabled(bool)for compatibility while adding the completeconfigure_pedersen_cache(...)APIThe cache remains thread-local for the native execution hot path. Its configured capacity therefore applies independently to each native worker thread, while the telemetry aggregates activity across the process.
Exact Madara dependency base
This PR is intentionally based on
7e263feb594cf95e0ec000a83520b9ed5c827855, the commit taggedv0.9.0-rc.6.That is the exact source release resolved as
cairo-native 0.9.0-rc.6inmadara-alliance/madara@daaacf0055fbea1dca67b49aab5a74426efbf49c. The PR base branch points directly to that tag commit, so the diff remains limited to the Pedersen-cache work needed by Madara.Validation
cargo test pedersen_cache: 2 passedcargo clippy --workspace --all-targets --all-features -- -D warnings: passedcargo fmt --all -- --check: passedgit diff --check: passedcargo check -p mc-exec: passedcargo check -p madara: passedDownstream integration: madara-alliance/madara#1250