fix: make FSR rotation quota-safe - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Fast Snapshot Restore rotation safe under the five snapshot/AZ quota and recover automatically from partial or previously failed transitions.
Rotation contract
For snapshots N (newest), N-1, and N-2:
enabledin every configured AZ and each AZ has at least oneFastSnapshotRestoreCreditsBalancecredit.Why
The current controller submits all AZs in one request, does not retry a missing AZ, treats
failedas terminal, and deletes expired snapshots before FSR reconciliation. With a quota of five, that left the Sep 10 Pathfinder snapshot enabled only inap-northeast-1cwhile Sep 8 and Sep 9 consumed four slots.Changes
disablingas not yet cold.Deployment artifacts
ghcr.io/karnotxyz/gemini:sha-0e10120sha256:d40faf04542b854b7bb7c35b38bf13606d428affc4676e8863f9e960286db073Validation
go test ./...go vet ./...git diff --checkNo AWS or Kubernetes resources are changed by this PR.