Conversation
heemankv
reviewed
Aug 29, 2026
|
|
||
| pub(crate) const USE_COMMITTED_FEES_ENV: &str = "SNOS_REPLAY_USE_COMMITTED_FEES"; | ||
|
|
||
| pub(crate) fn is_enabled() -> bool { |
Collaborator
There was a problem hiding this comment.
Could we parse this once at the rpc-replay configuration boundary and pass the selected mode explicitly through PieGenerationInput instead of reading process-global environment state inside generate-pie? This setting decides whether SNOS follows Blockifier fees or the Rust-canonical committed fee state, so it should be visible and testable in the invocation configuration. Invalid values should also fail fast rather than silently selecting Blockifier mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety
SNOS_REPLAY_USE_COMMITTED_FEESremains disabled by default. Invalid values are ignored, and incomplete or mismatched receipt data aborts reconciliation.Validation