fix(shipment): rename status purchased→created, remove choices constraint, enrich tracker event#998
Open
fix(shipment): rename status purchased→created, remove choices constraint, enrich tracker event#998
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Rename
purchased→createdstatusThe shipment status
purchasedis renamed tocreatedto better reflect semantics — a label being created is not the same as a purchase. All Python, CLI, and test references updated.2. Shipment.status: plain CharField (no choices constraint)
Removes
choices=SHIPMENT_STATUSfromShipment.status. Future statuses need no Django migrations. Data migration runsRunPythonto update existingpurchasedrows tocreatedbefore the field alteration.3. Tracker created event — full timestamp fields
The synthetic 'created' event injected when a shipment tracker is first created now includes:
date: YYYY-MM-DDtime: HH:MM AM/PM (consistent with carrier parsers)timestamp: ISO 8601 UTCstatus: 'created',code: 'CREATED',description: 'Shipment label created'4. Pricing signal fix
Removed
'created'from the fee-capture exclusion list — fees should be captured when a shipment reachescreatedstatus (label purchased), not suppressed.Tests
All server tests pass (410+ tests across core, proxy, manager, events, graph, orders, documents, admin, pricing).