Fix storage-screen layout overflows (#47 horizontal, #43 vertical) - #49
Merged
Conversation
The party strip's 96pt minimum cell width put its layout width at ~732pt (7 cells plus gaps), wider than the center column at common viewport sizes. The overflowing strip expanded the center Ui's layout width, so the box grid below laid out under the detail panel; the clipped right columns had truncated interact rects and silently dropped clicks and drag-releases. Lower the cell floor to 40pt so the strip always fits the column's 380pt minimum (cell text already elides). Pin it with a kittest that asserts the strip and the grid end left of the detail panel, and retarget the drag test at the grid's rightmost column, which used to swallow the drop. Fixes #47. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NruQyKNvf4kyzfjhAMJBWN
At short windows (640×400, the #38 repro size) the center column — header, party strip, three wrapped rows of box tabs, the 40pt-floor grid and the action rows — exceeded the viewport height, pushing the action row below the bottom edge where it could not be clicked. Two vertical savings close the gap. Below 430pt of height or 480pt of width the box tabs compact to numbered tabs on a single row, moving the per-box count and the live-box note into each tab's tooltip. And the grid cell floor drops from 40pt to 34pt, the true minimum for its two text lines plus inner margins. The compacted column now bottoms out around 380pt. Pin it by moving the action-row kittest from 640×480 down to 640×400 and asserting the button's rect lies inside the viewport before clicking it. Fixes #43. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NruQyKNvf4kyzfjhAMJBWN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two storage-screen layout fixes, one commit each:
Party strip overflow (fixes #47). The strip's 96pt minimum cell width put its layout width at ~732pt, wider than the center column at common sizes; the overflow expanded the center
Ui, so the box grid laid out under the detail panel and its clipped right columns silently dropped clicks and drag-releases. The cell floor is now 40pt, so the strip always fits the column's 380pt minimum (cell text already elides). Pinned by a kittest asserting the strip and grid end left of the detail panel, and by retargeting the drag test at the previously clipped rightmost grid column.Vertical overflow at short viewports (fixes #43). At 640×400 the column's vertical floor exceeded the viewport, pushing the action row off-screen. Below 430pt of height / 480pt of width the box tabs now compact to numbered tabs on one row (count and live-box note move to tooltips), and the grid cell floor drops to 34pt — the true two-text-line minimum. The column now bottoms out around 380pt. The action-row kittest moves from 640×480 to the 640×400 repro size and asserts the button's rect lies inside the viewport before clicking it.
Both pin tests were verified to fail against the unfixed layout.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NruQyKNvf4kyzfjhAMJBWN
Generated by Claude Code