Repository navigation
Preserve request headers and enforce frontend type checks - #1
Closed
katalinawinemixer wants to merge 1 commit into
Closed
katalinawinemixer wants to merge 1 commit into
katalinawinemixer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON request helper dropped headers supplied as a Headers object or tuple list. Normalize with Headers and retain explicit content types and cancellation signals. Add regressions for authentication and custom headers.
The root build skipped frontend type checking. Add that check, align the app with the root React 19 runtime and type packages, and import the missing Run type in SavedPage. Add CI and verification commands. Pin the patched shell-quote 1.11.0 release, which satisfies the repository’s three-day dependency cooldown.
Validation: 3 passing Bun tests, backend and frontend TypeScript checks, production UI build, ESLint (zero errors, 3 existing warnings), frozen Bun lockfile, workflow YAML validation, and
git diff --check. Header tests failed before the fix. The original test command found no test files, and frontend types failed when checked separately.Remaining issues:
bun auditstill reports advisories across 30 other package names. The shell-quote critical finding is removed, but this is not a complete dependency remediation. The build retains a large-chunk warning. External provider integrations and Playwright end-to-end workflows were not exercised.