Fix the v0.2.0 mac universal release build - #9
Merged
Conversation
…chFiles The agent bundle ships both darwin platform packages for voice cloning (the addon picks by os.arch() at runtime), so their Mach-O files are identical in the x64 and arm64 passes of the universal build — electron-builder rejects the merge unless they're covered by x64ArchFiles. This is what failed the v0.2.0 mac release build (the retries were mislabeled as notarization flakes). Verified locally: the universal DMG builds clean with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.2.0 mac build failed at the universal merge: the agent bundle ships both darwin sherpa-onnx platform packages (voice cloning), whose Mach-O files are identical across the x64 and arm64 passes — electron-builder requires them declared in x64ArchFiles. Verified locally: the universal DMG builds clean with this change. Also includes the CI publish-never fix for the Windows smoke build.