[katulevskiy]

Upstream mirror

Source: zeronsh#663
Original author: @RemingtonWilcox
Original revision: d985d7940ea22c92876e12d2cafb5459d96f2d7a

This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty [skip ci] commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.

---

Summary

• On the local device, New project's locations end with a Browse in File Explorer… row (Browse in Finder… on macOS, Browse folders… elsewhere). It opens the native folder picker, with the system's favorites and New folder.
• Choosing a folder there is the confirmation, so it's added directly. Cancel returns to the palette, and a picker error shows in the palette's error row.
• The row filters by its label like any other location and is reachable with ↑↓ and Enter.
• The dialog only reaches this device's folders, so remote devices keep the in-app browser unchanged.
• The pick goes through add_space_create, the tail of the palette's own Add project (split out of submit_add_space, behaviour unchanged), so a folder that already has a project switches to it instead of adding a duplicate.

Worth a close look

• The picked folder's git_detected comes from a local .git probe, the same check ListFolders uses; the device's SpacesSync re-verifies it.
• The dialog uses gpui's prompt_for_paths, which the composer's attach button already uses on every platform.
• Projects saved by older builds with mixed separators (C:\Users\me/code) aren't matched by the duplicate check here or in the in-app browser. That's a separate small PR (same-folder-paths).
• The test setup of devices_locations_folders_and_back_clear_stale_state moved into a small shell_with_devices helper so the new test can share it. Projects: open New project on the device already in context zeronsh/zeron#690 adds the same helper; whichever lands second drops its copy on rebase.
• Add folder creation to New project on desktop and iOS zeronsh/zeron#685 (folder creation in New project) touches the same palette; the two haven't been tried together.

Test plan

• local_device_offers_the_os_folder_dialog: no row on a remote device; on the local device the row shows, filters to "browse", opens the dialog on Enter, and Cancel returns to Locations. Fails without the change.
• Existing project-flow tests still pass.
• cargo test --locked -p zeron-ui --lib on Windows 11 x64: 1482 passed, 5 ignored.
• rustfmt --check clean; no new warnings in the changed code.
• Manual, Windows 11 x64, on an earlier build of this branch: the row appears under Home and the drives, opens the File Explorer folder picker, adds the picked folder, and Cancel returns to the palette.
• Not re-checked manually after this trim. Not checked on macOS (Finder) or Linux (portal).
• Not covered by a test: a picked folder being added (needs a running engine).
• Linux UI and core suites on the fork's CI (ui-tests workflow): https://github.com/RemingtonWilcox/zeron/actions/runs/37240695980

Screenshots

Dark mode. The row reuses the palette's existing row style and arrow icon.

🤖 Generated with Claude Code

[contribution-manager-katulevskiy]

Contribution Manager

needs triage · medium risk · untriaged

Open review workspace · Revision b003e707

Next actions:

• Direction decision needed
• Scope, risk, and platform triage needed
• Independent code review needed
• Required check: core-tests (missing)

This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs.