Repository navigation
Add Vesper to the built-in theme catalog - #130
Draft
katulevskiy wants to merge 4 commits into
Draft
katulevskiy wants to merge 4 commits into
katulevskiy wants to merge 4 commits into
Conversation
Contribution Managerneeds triage · medium risk · untriaged Open review workspace · Revision Next actions:
This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream mirror
Source: zeronsh#654
Original author: @woosal1337
Original revision:
056b0bdfdef124e7d1ef0324021cfa02f9e2325fThis PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty
[skip ci]commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.Summary
Add Vesper to the dark theme menu in Appearance settings. Vesper currently needs a custom import. This change makes it a bundled choice with a neutral dark background, orange accents, and mint strings.
Approach
vesperfamily andvesper-darkvariant through the existing palette builder incrates/theme/src/builtins.rs.This follows the built-in curation structure introduced by PR #215. The catalog contains 31 variants across 20 families.
Source
Vesper by Rauno Freiberg, revision
9043f3849b776949445f0cd4990365959cca35a3, MIT license. The palette also matches the earlier Vesper port for JetBrains Air.Validation
cargo test --locked -p zeron-theme: 25 passed.rustfmt --edition 2024 --config skip_children=true --check crates/theme/src/builtins.rs crates/theme/src/lib.rs: passed.git diff --check: passed.Visual review
Reviewed the matching native palette in Zeron 0.2.84 across the main workspace, composer, Appearance settings, palette menu, and code and diff preview.
This PR is a draft. The full
VisualFixturescene and state matrix, plus the full app build, remain pending.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.