Skip to content

Add Vesper to the built-in theme catalog - #130

Draft
katulevskiy wants to merge 4 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/654
Draft

katulevskiy wants to merge 4 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/654

Conversation

@katulevskiy

Copy link
Copy Markdown
Owner

Upstream mirror

Source: zeronsh#654
Original author: @woosal1337
Original revision: 056b0bdfdef124e7d1ef0324021cfa02f9e2325f

This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty [skip ci] commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.


Summary

Add Vesper to the dark theme menu in Appearance settings. Vesper currently needs a custom import. This change makes it a bundled choice with a neutral dark background, orange accents, and mint strings.

Approach

  1. Add the vesper family and vesper-dark variant through the existing palette builder in crates/theme/src/builtins.rs.
  2. Define all 26 UI roles, eight accent fields, 31 syntax roles, and 16 ANSI colors. Include explicit Markdown colors and neutral selections.
  3. Keep comments opaque for readability. Recommend opaque surfaces through the existing surface preference model.
  4. Record the exact upstream revision, MIT license, and resolved palette hash. Update the theme guide, catalog checks, and license notices.

This follows the built-in curation structure introduced by PR #215. The catalog contains 31 variants across 20 families.

Source

Vesper by Rauno Freiberg, revision 9043f3849b776949445f0cd4990365959cca35a3, MIT license. The palette also matches the earlier Vesper port for JetBrains Air.

Validation

  1. cargo test --locked -p zeron-theme: 25 passed.
  2. rustfmt --edition 2024 --config skip_children=true --check crates/theme/src/builtins.rs crates/theme/src/lib.rs: passed.
  3. git diff --check: passed.
  4. Exported the compiled variant. Its UI, accent, syntax, and terminal values match the installed native palette. Checked its SHA-256 hash with a separate calculation.
  5. The new regression test checks all 31 syntax roles, text and status contrast on nine surfaces, button text, and registry validation.

Visual review

Reviewed the matching native palette in Zeron 0.2.84 across the main workspace, composer, Appearance settings, palette menu, and code and diff preview.

This PR is a draft. The full VisualFixture scene and state matrix, plus the full app build, remain pending.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added the review:needs-triage Managed by Contribution Manager label Oct 6, 2026
@contribution-manager-katulevskiy

contribution-manager-katulevskiy Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Contribution Manager

needs triage · medium risk · untriaged

Open review workspace · Revision f70b1667

Next actions:

  • Direction decision needed
  • Scope, risk, and platform triage needed
  • Author has marked this PR as draft
  • Independent code review needed
  • Required check: core-tests (missing)

This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs.

@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added cm:inbox Contribution Manager: waiting for triage and removed review:needs-triage Managed by Contribution Manager labels Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cm:inbox Contribution Manager: waiting for triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants