Skip to content

Transcript: make web tool links clickable - #131

Draft
katulevskiy wants to merge 3 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/653
Draft

katulevskiy wants to merge 3 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/653

Conversation

@katulevskiy

Copy link
Copy Markdown
Owner

Upstream mirror

Source: zeronsh#653
Original author: @SinaKhalili
Original revision: a047909fe6c96405f1445e0f43b5f96cabf207a4

This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty [skip ci] commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.


Summary

  • Make URLs in tool headers, invocations, and output use the existing transcript link controls: browser preference, destination menu, copy, and keyboard navigation. This includes Codex and agent transcripts.
  • Preserve Codex page-action URLs and keep long invocation URLs intact. Handle nested link pointer gestures without toggling the containing tool disclosure.
  • Add URL parsing, Codex normalization, long-URL regression tests, and an isolated native web-tool fixture. No new dependencies, wire/schema changes, or version bump.

Test plan

  • cargo test --locked -p zeron-ui --lib -- --test-threads=1 — 1,315 passed on the final implementation.
  • cargo test --locked -p zeron-markdown — 48 passed.
  • Run cargo test --locked -p zeron-harness --no-fail-fast -- --test-threads=1. All integration targets passed; 303/304 unit tests passed. The unchanged opencode::tests::stalled_prompt_post_has_a_bounded_timeout fails at crates/harness/src/opencode/tests.rs:386 with Elapsed(()); it passes in isolation on unchanged main but fails locally on this branch. This draft leaves that discrepancy explicit for triage. Earlier runs also hit timing-sensitive Devin discovery and shell-probe failures that passed on the final run.
  • cargo clippy --locked -p zeron-ui -p zeron-markdown --all-targets — completed with existing warnings; no new lint categories in the changed code.
  • Run Clippy for all three touched crates. Harness test checking is blocked by existing clippy::non_octal_unix_permissions errors at crates/harness/src/skills.rs:874,911; that file is unchanged.
  • git diff --check; formatting limited to the edited code.
  • Native macOS fixture: open a tool URL with the pointer, inspect its keyboard-opened context menu, and capture light/dark × frosted/opaque appearances. Loopback website, synthetic chat, temporary storage; no real agent/account data.
  • Capture before/after screenshots from main and this branch without committing images.
  • Upload the before/after and interaction screenshots as GitHub attachments.
  • Native Linux/Windows manual UI checks and external-browser launch.
  • CI must pass and the local harness timeout discrepancy must be resolved before marking ready.
Before/after screenshots and link interaction
Appearance Before After
Dark / Frosted Before dark-frosted After dark-frosted
Dark / Opaque Before dark-opaque After dark-opaque
Light / Frosted Before light-frosted After light-frosted
Light / Opaque Before light-opaque After light-opaque

Tool link destination menu

Tool link opened in the browser

@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added the review:needs-triage Managed by Contribution Manager label Oct 6, 2026
@contribution-manager-katulevskiy

contribution-manager-katulevskiy Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Contribution Manager

needs triage · medium risk · untriaged

Open review workspace · Revision 6b59f003

Next actions:

  • Direction decision needed
  • Scope, risk, and platform triage needed
  • Author has marked this PR as draft
  • Independent code review needed
  • Required check: core-tests (missing)

This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs.

@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added cm:inbox Contribution Manager: waiting for triage and removed review:needs-triage Managed by Contribution Manager labels Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cm:inbox Contribution Manager: waiting for triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants