Skip to content

Composer: let the question panel's answer input grow past one line - #138

Open
katulevskiy wants to merge 3 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/629
Open

katulevskiy wants to merge 3 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/629

Conversation

@katulevskiy

Copy link
Copy Markdown
Owner

Upstream mirror

Source: zeronsh#629
Original author: @katulevskiy
Original revision: de0c765ea17cc865cbe6043c2dd9527481852e71

This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty [skip ci] commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.


Summary

  • While an agent question is pending, the question panel replaces the composer pill and reuses the same input for the free-text answer. That input's height cap (viewport_height) was only written by the pill's own render path, which the panel's render returns before reaching, so the panel inherited whatever the last pill render left.
  • In an established thread the empty pill is compact and leaves a one-line cap, so typing a multi-row answer scrolled inside a single row instead of growing the panel.
  • The panel now sets the full textarea cap each time it renders. The pill path rewrites it as soon as the panel goes away, so nothing changes there.
  • Only the desktop composer is touched. The visible difference is that the answer input grows with its content.
  • Not looked at: a question with many choices in a small window, where the taller input plus the choices may need a max height on the panel.

Screenshot

Rendered with GPUI in an established thread (so the composer is the compact pill) with a pending question and a five-row typed answer. Left is main, right is this branch. On main the answer is scrolled inside a single row, so the typed text isn't readable; with the fix all five rows show and the panel grows to fit.

Question panel before and after

The image lives on a separate pr-assets-question-panel branch of my fork, so it isn't part of this diff.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

katulevskiy and others added 2 commits September 28, 2026 21:30
While a question is pending the panel hosts the shared composer input in
place of the composer pill. The input's height cap (viewport_height) is
only written by the pill's own render path, which the wizard branch returns
before reaching, so the panel inherited whatever the last pill render left.
In an established thread the empty pill is compact and leaves a one-line
cap, so a multi-row answer scrolled inside a single row instead of growing.

Set the full textarea cap for the panel each render; the pill path rewrites
it as soon as the panel goes away.
@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added the review:needs-triage Managed by Contribution Manager label Oct 6, 2026
@contribution-manager-katulevskiy

contribution-manager-katulevskiy Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Contribution Manager

needs triage · medium risk · untriaged

Open review workspace · Revision 60557053

Next actions:

  • Direction decision needed
  • Scope, risk, and platform triage needed
  • Independent code review needed
  • Required check: core-tests (missing)

This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs.

@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added cm:inbox Contribution Manager: waiting for triage and removed review:needs-triage Managed by Contribution Manager labels Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cm:inbox Contribution Manager: waiting for triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant