Repository navigation
Composer: let the question panel's answer input grow past one line - #138
Open
katulevskiy wants to merge 3 commits into
Open
katulevskiy wants to merge 3 commits into
katulevskiy wants to merge 3 commits into
Conversation
While a question is pending the panel hosts the shared composer input in place of the composer pill. The input's height cap (viewport_height) is only written by the pill's own render path, which the wizard branch returns before reaching, so the panel inherited whatever the last pill render left. In an established thread the empty pill is compact and leaves a one-line cap, so a multi-row answer scrolled inside a single row instead of growing. Set the full textarea cap for the panel each render; the pill path rewrites it as soon as the panel goes away.
Source: zeronsh#629 Source revision: de0c765
Contribution Managerneeds triage · medium risk · untriaged Open review workspace · Revision Next actions:
This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream mirror
Source: zeronsh#629
Original author: @katulevskiy
Original revision:
de0c765ea17cc865cbe6043c2dd9527481852e71This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty
[skip ci]commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.Summary
viewport_height) was only written by the pill's own render path, which the panel's render returns before reaching, so the panel inherited whatever the last pill render left.Screenshot
Rendered with GPUI in an established thread (so the composer is the compact pill) with a pending question and a five-row typed answer. Left is
main, right is this branch. Onmainthe answer is scrolled inside a single row, so the typed text isn't readable; with the fix all five rows show and the panel grows to fit.The image lives on a separate
pr-assets-question-panelbranch of my fork, so it isn't part of this diff.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.