Repository navigation
Titles: follow-the-session from the session harness and model - #146
Open
katulevskiy wants to merge 4 commits into
Open
katulevskiy wants to merge 4 commits into
katulevskiy wants to merge 4 commits into
Conversation
Contribution Managerneeds triage · medium risk · untriaged Open review workspace · Revision Next actions:
This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream mirror
Source: zeronsh#614
Original author: @devshekhawat
Original revision:
0c9e6036116a5714dd208dbbeb45a29b8314c884This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty
[skip ci]commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.Opencode sessions never got an intelligent title — every new thread fell back to truncating the prompt. Two stacked causes, two commits:
1. Opencode: title runs from the session harness (harness)
supports_titlesexcluded OpenCode, so the engine failed over to another harness (often unauthed) and gave up.OpencodeHarness::run_titleadded: request sanitized (no resume/worktree/attachments/MCP/model options, no auto-approve),title_onlythreaded throughSession/BusCtxsopermission.askedrepliesrejectinstead ofonce. Questions still resolve empty and never block.check why the login redirect loops on staging→Staging Login Redirect Loop, Completed, zero tool calls.title_runs_reject_tool_permissions(v1+v2 fixture).2. Engine: title follow-the-session with the session's own model (engine)
request.modelis threaded throughmaybe_generate/generate/run_title_model; with nothing pinned and the title on the session's own harness, its model is reused. Cross-harness titles keep the catalog guess; pinned settings win as before.session_model_is_reused_for_same_harness_titles.How to verify: new opencode thread with Thread naming on follow-the-session → 3–5 word title within ~15s;
grep -i auto-titl data/logs/zeron-headed.log.Suites: engine titles 5 passed; harness lib incl. all 61 opencode tests, claude (16), codex (27) green — one pre-existing timing flake (
stalled_prompt_post_has_a_bounded_timeout) fails on pristine main too.rustfmt --checkclean; no new clippy warnings. Supersedes zeronsh#611 and zeronsh#613 (closed).