Repository navigation
Persist embedded browser sessions across tabs and app restarts - #152
Open
katulevskiy wants to merge 16 commits into
Open
katulevskiy wants to merge 16 commits into
katulevskiy wants to merge 16 commits into
Conversation
… cleanup Require explicit storage results, validate deletion in every store, and preserve primary failures while attempting all profile cleanups. Add opt-in native cookie and same-process reopen diagnostics. Validated on macOS 27 arm64: release check/build and native tests pass. Two complete storage runs correctly fail on cookies returning after process restart; all profile cleanups pass. Cookie deletion persistence remains unresolved.
This reverts commit dffcec2.
Source: zeronsh#573 Source revision: 515642b
contribution-manager-katulevskiy
Bot
added
the
review:needs-triage
Contribution Managerneeds triage · medium risk · untriaged Open review workspace · Revision Next actions:
This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs. |
contribution-manager-katulevskiy
Bot
added
cm:inbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream mirror
Source: zeronsh#573
Original author: @jsgrrchg
Original revision:
515642b2cfeb7636b99cd190124914e0eedf6562This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty
[skip ci]commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.Embedded browser logins are currently lost when Zeron restarts, and on Linux also when the last browser tab closes. This change reopens persistent website data for the same Zeron profile on Linux and macOS 14+, so valid persistent sessions survive both actions.
Validation
cargo check --locked -p zeron-ui --tests --example browser-fixture --features browser-fixturepassed.cargo test --locked -p zeron-ui --lib browser --features browser-fixture -- --test-threads=1passed: 21 tests, with the display-dependent lifecycle test ignored in this run. That lifecycle test also passed separately under Xvfb during implementation.Native macOS execution was not available in the Linux development environment; its validation is configured in CI. Windows continues to use the default external browser. This does not add password autofill or tab restoration, and websites can still expire or revoke sessions.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.