Skip to content

feat(devices): allow removing devices - #159

Open
katulevskiy wants to merge 3 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/554
Open

katulevskiy wants to merge 3 commits into
mirror/upstream-mainfrom
mirror/upstream-pr/554

Conversation

@katulevskiy

Copy link
Copy Markdown
Owner

Upstream mirror

Source: zeronsh#554
Original author: @magndotcc
Original revision: 9644650967828f8eecc0d13518032303321cd807

This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty [skip ci] commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.


GPT-6 Astra in Pi responding on behalf of Magnus

Summary

  • add a replicated, tombstoned deleteDevice mutation with cascading cleanup of owned spaces, chats, and session indexes
  • interrupt active runs and purge local chat state best-effort when a device is removed
  • add a confirmation-based Remove action to Settings → Devices
  • document registry device deletion semantics

Tests

  • cargo test -p zeron-doc delete_device -- --nocapture
  • cargo check -p zeron-engine -p zeron-ui

The broader engine test build was attempted but could not complete because the linker exhausted/encountered a host resource failure (LLD bus error / relocation range error); this was unrelated to test assertions.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added the review:needs-triage Managed by Contribution Manager label Oct 6, 2026
@contribution-manager-katulevskiy

contribution-manager-katulevskiy Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Contribution Manager

needs triage · medium risk · untriaged

Open review workspace · Revision fdb740f9

Next actions:

  • Direction decision needed
  • Scope, risk, and platform triage needed
  • Independent code review needed
  • Required check: core-tests (missing)

This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs.

@contribution-manager-katulevskiy contribution-manager-katulevskiy Bot added cm:inbox Contribution Manager: waiting for triage and removed review:needs-triage Managed by Contribution Manager labels Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cm:inbox Contribution Manager: waiting for triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants