Repository navigation
feat(desktop): add persistent UI scaling - #99
Open
katulevskiy wants to merge 2 commits into
Open
katulevskiy wants to merge 2 commits into
katulevskiy wants to merge 2 commits into
Conversation
Contribution Managerneeds triage · medium risk · untriaged Open review workspace · Revision Next actions:
This summary is maintained by the review app. Decisions and test evidence are recorded in the workspace; the app does not merge PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream mirror
Source: zeronsh#705
Original author: @katulevskiy
Original revision:
fedfdd8e5737925db442bacfeb24ac5d9ae60850This PR is an isolated Contribution Manager pilot mirror. Its reviews, checks and merge state are separate from upstream. An empty
[skip ci]commit suppresses automatic bulk CI; the code tree matches the imported upstream revision.Add persistent whole-interface scaling in Settings → Appearance → Interface scale. The minus/plus controls and
Ctrl+Shift+Plus/Ctrl+Shift+Minusadjust the UI from 50% to 200% in 10-point steps;Ctrl+Shift+0resets to 100%. macOS also accepts Command equivalents.Text, icons, spacing, and panes scale together without changing font preferences or native window dimensions. The device-local preference saves immediately and restores on startup. Pointer hit testing, pixel scrolling, IME coordinates, and native browser placement follow the selected scale. Reserved zoom shortcuts survive keymap edits and work from settings and a focused conversation composer.
Supporting dependency
Depends on zeronsh/zui#14, which adds independent GPUI window scaling. A temporary pinned Cargo patch makes this branch build and keeps GPUI and gpui-base on the same types. After that change merges, replace the patch with the upstream revision before merging this PR.
Validation
cargo test --locked -p zeron-ui --lib -- --test-threads=1).cargo check --locked -p zeronpassed.Screenshots
The same 1440 × 1080 native app window at each scale. Captured from the production shell using the reproducible fixture documented in docs/ui-scale.md.
Light · 120%:
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.